-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbose logging of cache and queues #1528
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
a2b160b
to
43c0137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, lgtm
pkg/scheduler/logging.go
Outdated
} | ||
|
||
func logSnapshotIfVerbose(log logr.Logger, s *cache.Snapshot) { | ||
if logV := log.V(5); logV.Enabled() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, our max log level is 6
. So is it better to use V(6)
here and Line 37 as well?
log.V(6).Info("The job is no longer active, clear the workloads admission") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Change-Id: Iabd963a1dfcad8730949e945d85bef64fcd4017c
43c0137
to
aa40831
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 755a673fe5d9f86f7e1230d38cd6867928f5419f
|
Btw, this is how the dump looks:
I'm preparing another PR with instructions on how to produce it. |
It's great to see. Thanks. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Produces a dump of the cache into the logs at log level 5.
A dump of the cache and queues can be logged on demand using SIGUSR2, regardless of the log level.
Refactored some existing dump methods used for testing to use slices for better performance and simpler formatting.
Which issue(s) this PR fixes:
Fixes #1438 #1437
Special notes for your reviewer:
Does this PR introduce a user-facing change?