Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm]Add script to sync webhookConfigurations to helm charts automatically #1560

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

B1F030
Copy link
Member

@B1F030 B1F030 commented Jan 9, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Implement scripts to sync webhookConfigurations to helm charts and validate automatically.

Which issue(s) this PR fixes:

Fixes #1461

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2024
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 1f7db84
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65b4adfff3cd7700088b5b5a

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @B1F030. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2024
@B1F030
Copy link
Member Author

B1F030 commented Jan 9, 2024

There're still several places to reslove:
L1
mutate--v1-pod
validate--v1-pod

@kerthcet
Copy link
Contributor

kerthcet commented Jan 9, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2024
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't yet reviewed scripts.

charts/kueue/templates/webhook/webhook.yaml Outdated Show resolved Hide resolved
@B1F030 B1F030 changed the title [Helm]sync webhookConfigurations to helm charts [Helm]Add script to sync webhookConfigurations to helm charts automatically Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2024
@B1F030
Copy link
Member Author

B1F030 commented Jan 10, 2024

I think this failed test will not happen if the charts/kueue/templates/webhook/webhook.yaml is copied from config/components/webhook/manifests.yaml.
What do you think? @tenzen-y
Now it's basically done. Feel free to review. I will suqash the commits after this failed test confirmed ok.

@tenzen-y
Copy link
Member

I think this failed test will not happen if the charts/kueue/templates/webhook/webhook.yaml is copied from config/components/webhook/manifests.yaml. What do you think? @tenzen-y Now it's basically done. Feel free to review. I will suqash the commits after this failed test confirmed ok.

@B1F030 We can move this forward this PR after we merge a commit to fix webhookConfiguration.
It means that we need to open another PR to fix webhookConfiguration, first.

@B1F030
Copy link
Member Author

B1F030 commented Jan 11, 2024

@B1F030 We can move this forward this PR after we merge a commit to fix webhookConfiguration. It means that we need to open another PR to fix webhookConfiguration, first.

OK.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 15, 2024
@B1F030
Copy link
Member Author

B1F030 commented Jan 15, 2024

/cc @tenzen-y
This PR is generally done.
Feel free to review anytime, thank you!

@tenzen-y
Copy link
Member

I would like to give the first pass to @trasc.

@B1F030
Copy link
Member Author

B1F030 commented Jan 26, 2024

/retest

Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM

hack/update-helm.sh Show resolved Hide resolved
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 61297f31bf0b2f209fcb201335d113cb5ba61c16

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 27, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2024
…idate automatically

Signed-off-by: B1F030 <646337422@qq.com>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48714bff0353a389dc73246871f1cc0953dbb2c0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: B1F030, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0edd519 into kubernetes-sigs:main Jan 29, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Jan 29, 2024
@B1F030 B1F030 deleted the helm-webhook branch January 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically sync webhookConfigurations to helm charts
5 participants