-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Helm]Add script to sync webhookConfigurations to helm charts automatically #1560
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Hi @B1F030. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There're still several places to reslove: |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't yet reviewed scripts.
I think this failed test will not happen if the |
@B1F030 We can move this forward this PR after we merge a commit to fix webhookConfiguration. |
OK. |
/cc @tenzen-y |
I would like to give the first pass to @trasc. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 61297f31bf0b2f209fcb201335d113cb5ba61c16
|
…idate automatically Signed-off-by: B1F030 <646337422@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
LGTM label has been added. Git tree hash: 48714bff0353a389dc73246871f1cc0953dbb2c0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: B1F030, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Implement scripts to sync webhookConfigurations to helm charts and validate automatically.
Which issue(s) this PR fixes:
Fixes #1461
Special notes for your reviewer:
Does this PR introduce a user-facing change?