Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jobset] Add prebuilt workload support. #1575

Merged
merged 3 commits into from
Jan 15, 2024
Merged

[jobset] Add prebuilt workload support. #1575

merged 3 commits into from
Jan 15, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Jan 12, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds prebuilt workload support for jobset.

Which issue(s) this PR fixes:

Relates to #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add Prebuilt Workload support for JobSets.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 12, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 12, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 12, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 2cf512b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65a4e04faf8d5600097d61aa

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 12, 2024
mimowo
mimowo reviewed Jan 12, 2024
View reviewed changes
pkg/controller/jobs/jobset/jobset_webhook.go Outdated Show resolved Hide resolved
pkg/controller/jobs/job/job_webhook.go Show resolved Hide resolved
pkg/controller/jobs/jobset/jobset_webhook.go Outdated Show resolved Hide resolved
pkg/util/testingjobs/jobset/wrappers.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 12, 2024
mimowo
mimowo reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the logic LGTM.

One remaining comment is about testing. The fact that the prebuilt-workload is supported does not seem tested (asked to clarify in #1575 (comment)).

The preferred way to do for me would be a baseline scenario integration test. JobSet is a key CRD we will use for MultiKueue, so seems desired to have an integration test for it, but unit test is acceptable to me.

@alculquicondor
Copy link
Contributor

We can do that as a follow up.

This is assigned, but there hasn't been any progress
#1463

@mimowo
Copy link
Contributor

mimowo commented Jan 12, 2024

We can do that as a follow up.

This is assigned, but there hasn't been any progress
#1463

Sounds good, also the enablement of prebuilt support for JobSet will be indirectly tested on higher level when we have full support for JobSet in MK.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c63dcbb47f37e1ca26911345fe19da6551227406

alculquicondor
alculquicondor reviewed Jan 12, 2024
View reviewed changes
pkg/controller/jobframework/interface.go Outdated Show resolved Hide resolved
pkg/controller/jobs/job/job_webhook.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/validation.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2024
@mimowo
Copy link
Contributor

mimowo commented Jan 15, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6a40b56991918632c06494e4d67442fcc42a1257

tenzen-y
tenzen-y reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 41c8f43 into kubernetes-sigs:main Jan 15, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Jan 15, 2024
@trasc trasc deleted the prebuilt-wl-jobset branch January 15, 2024 18:05
@alculquicondor alculquicondor mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@mimowo mimowo

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trasc @alculquicondor @mimowo @k8s-ci-robot @tenzen-y