Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase reconcilers for Pod #1589

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Increase reconcilers for Pod #1589

merged 1 commit into from
Jan 17, 2024

Conversation

alculquicondor
Copy link
Contributor

@alculquicondor alculquicondor commented Jan 16, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Increase the number of reconcilers for Pod in the default configuration and E2E tests.

Also doing the same for Workload object, which are expected to be a significant number of objects.

Which issue(s) this PR fixes:

Fixes #1448

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Increase the default number of reconcilers for Pod and Workload objects to 5, each.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify Netlify
Copy link

netlify bot commented Jan 16, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 39337b2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65a6d00a2eab3a0008c4ba9d

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2024
@alculquicondor
Increase reconcilers for Pod
39337b2 
Change-Id: Ibee32beacf7c6e705a5f7d0ca69d5d6a4fa9944a
@alculquicondor
Copy link
Contributor Author

The error happened during cleanup and it doesn't seem related to this change. But I opened #1591 to investigate.

mimowo
mimowo reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM, asked some questions to better understand the context.

config/components/manager/controller_manager_config.yaml
@@ -13,10 +13,11 @@ leaderElection:
controller:
groupKindConcurrency:
Job.batch: 5
Pod.: 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the default if not specified? Also, why only batch.Job and Pod frameworks are picked to have a custom value (5)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is one.

We could add all integrations, but this is just a default configuration that should work for most users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, and we guesstimate to need more for pods, because there will be many of such objects, because the worker is invoked per pod, not per the grouping object as for say "MPIJob", or "PyTorchJob"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that make sense it defaults according to the number of CPUs available / cgroups CPU quota?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This number is a default, users will have to pick up what makes sense for them.

We just have to pick some numbers that work at a reasonable scale (~50 nodes).
I picked the number based on the default number of workers in kcm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, we have concurrent-job-syncs: 5 indeed. I'm wondering if we should set 5 also for other Job CRDs, but that would probably be for another PR.

@alculquicondor
Copy link
Contributor Author

/retest

@mimowo
Copy link
Contributor

mimowo commented Jan 17, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5db6052880697585b3553652b7c80e6e3fc14a24

@k8s-ci-robot k8s-ci-robot merged commit 60177bf into kubernetes-sigs:main Jan 17, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Jan 17, 2024
@alculquicondor alculquicondor mentioned this pull request Mar 11, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti left review comments

@mimowo mimowo mimowo left review comments

@trasc trasc Awaiting requested review from trasc

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Increase the number of reconcilers for the Pod integration
4 participants
@alculquicondor @k8s-ci-robot @mimowo @astefanutti