Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[site] [website] Kueue RayCluster documentation #1607

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[site] [website] Kueue RayCluster documentation #1607

merged 1 commit into from
Jan 31, 2024

Conversation

vicentefb
Copy link
Contributor

@vicentefb vicentefb commented Jan 18, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds documentation for RayCluster integration with Kueue

Which issue(s) this PR fixes:

Fixes #1272

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds documentation for RayCluster integration with Kueue

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 18, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 5eeebe6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65ba8f60ddfa2400073642f4

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @vicentefb. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2024
@alculquicondor
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2024
@vicentefb vicentefb force-pushed the RayClusterDocumentation branch 6 times, most recently from b76515e to 524a221 Compare January 30, 2024 22:03
alculquicondor
alculquicondor reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
@astefanutti or @andrewsykim can you give an LGTM?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@vicentefb vicentefb force-pushed the RayClusterDocumentation branch from 24947ca to e23f14f Compare January 31, 2024 01:02
@vicentefb vicentefb force-pushed the RayClusterDocumentation branch from c00338e to 53111fa Compare January 31, 2024 02:14
@vicentefb vicentefb requested a review from andrewsykim January 31, 2024 02:14
@vicentefb vicentefb force-pushed the RayClusterDocumentation branch from 702c2b0 to 14d2e18 Compare January 31, 2024 07:36
@vicentefb vicentefb requested a review from andrewsykim January 31, 2024 07:37
astefanutti
astefanutti approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, astefanutti, vicentefb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicentefb
added documentation for RayCluster integration
5eeebe6 
added ray cluster sample yaml file

added more limitations

nit

NIT

nit

updated

nit

added version

nit
@vicentefb vicentefb force-pushed the RayClusterDocumentation branch from 96cd3f1 to 5eeebe6 Compare January 31, 2024 18:20
@vicentefb
Copy link
Contributor Author

/retest

@vicentefb vicentefb requested a review from astefanutti January 31, 2024 19:12
andrewsykim
andrewsykim reviewed Jan 31, 2024
View reviewed changes
site/content/en/docs/tasks/run_rayclusters.md

## Before you begin

1. Make sure you are using Kueue v0.6.0 version or newer and Kuberay 1.1.0 or newer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how we care that v1.1.0 is not release yet. Probably not a big deal since v1.1.0 will be out sometime in Feb

andrewsykim
andrewsykim reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 20621a6512de31b192065278ca46bc263ae3f091

@k8s-ci-robot k8s-ci-robot merged commit 5ed62e4 into kubernetes-sigs:main Jan 31, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Jan 31, 2024
@andrewsykim andrewsykim mentioned this pull request Feb 5, 2024
Merged
8 tasks
@alculquicondor
Copy link
Contributor

/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 13, 2024
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@vicentefb @kannon92
added documentation for RayCluster integration (kubernetes-sigs#1607)
d18728c 
added ray cluster sample yaml file

added more limitations

nit

NIT

nit

updated

nit

added version

nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@trasc trasc Awaiting requested review from trasc

@astefanutti astefanutti Awaiting requested review from astefanutti

Assignees

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Add support for RayCluster
5 participants
@vicentefb @k8s-ci-robot @alculquicondor @astefanutti @andrewsykim