Fix kueue crashing when clearing outdated assignment on log level 6

[mimowo]

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Kueue is crashing currently when the log is at level 6.

This is the error log:

goroutine 481 [running]:
k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0x175e3ae?})
	/go/pkg/mod/k8s.io/apimachinery@v0.28.6/pkg/util/runtime/runtime.go:56 +0xcd
panic({0x22b8780?, 0x3fa68e0?})
	/usr/local/go/src/runtime/panic.go:914 +0x21f
sigs.k8s.io/kueue/pkg/scheduler/flavorassigner.AssignFlavors({{0x2a96818?, 0xc000a64360?}, 0x14?}, 0xc000f9bc00, 0x4?, 0xc0011541e0, {0x0, 0x0, 0xc001805880?})
	/workspace/pkg/scheduler/flavorassigner/flavorassigner.go:245 +0x220
sigs.k8s.io/kueue/pkg/scheduler.(*Scheduler).getAssignments(0xc0007c6780, {{0x2a96818?, 0xc000a64360?}, 0xc000a64270?}, 0xc000f9bc00, 0xc000ebb838)
	/workspace/pkg/scheduler/scheduler.go:382 +0xf5
sigs.k8s.io/kueue/pkg/scheduler.(*Scheduler).nominate(0xc0007c6780, {0x2a8fac8, 0xc000c9e090}, {0xc001513ac0, 0x1, 0xd?}, {0xc000a64060, 0xc000a64090, 0xc000a640c0})
	/workspace/pkg/scheduler/scheduler.go:334 +0x931
sigs.k8s.io/kueue/pkg/scheduler.(*Scheduler).schedule(0xc0007c6780, {0x2a8fac8, 0xc000c9e090})
	/workspace/pkg/scheduler/scheduler.go:191 +0x166
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1()
	/go/pkg/mod/k8s.io/apimachinery@v0.28.6/pkg/util/wait/backoff.go:259 +0x22
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0xc000ebbe80?)
	/go/pkg/mod/k8s.io/apimachinery@v0.28.6/pkg/util/wait/backoff.go:226 +0x33
k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0x0?, {0x2a69100, 0xc000c9e0c0}, 0x1, 0xc000c2e000)
	/go/pkg/mod/k8s.io/apimachinery@v0.28.6/pkg/util/wait/backoff.go:227 +0xaf
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0x2a8fb00?, 0x0, 0x0, 0x0?, 0x0?)
	/go/pkg/mod/k8s.io/apimachinery@v0.28.6/pkg/util/wait/backoff.go:204 +0x7f
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext({0x2a8fac8, 0xc000c9e090}, 0xc000ca0000, 0xc0007c42d0?, 0xcc516e?, 0xd0?)
	/go/pkg/mod/k8s.io/apimachinery@v0.28.6/pkg/util/wait/backoff.go:259 +0x93
k8s.io/apimachinery/pkg/util/wait.UntilWithContext({0x2a8fac8?, 0xc000c9e090?}, 0x17d4907?, 0xc0006b2240?)
	/go/pkg/mod/k8s.io/apimachinery@v0.28.6/pkg/util/wait/backoff.go:170 +0x25
created by sigs.k8s.io/kueue/pkg/scheduler.(*Scheduler).Start in goroutine 394
	/workspace/pkg/scheduler/scheduler.go:119 +0x13a

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix Kueue crashing at the log level 6 when re-admitting workloads

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	a26bd79
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65b278cecd8bd400084e6098
😎 Deploy Preview	https://deploy-preview-1644--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mimowo]

/assign @tenzen-y @alculquicondor

[tenzen-y]

Nice catch :)

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a16044797d89027dd110a95eb9d35318526c75e7

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

/hold

[alculquicondor]

ah it just moved below

/hold cancel

[alculquicondor]

I think this needs to be cherry-picked to 0.5?

[tenzen-y]

Why is this PR merged in spite of /hold?

[tenzen-y]

I think this needs to be cherry-picked to 0.5?

Yes, we should do it:

kueue/pkg/scheduler/flavorassigner/flavorassigner.go

Lines 239 to 241 in 921b794

	if wl.LastAssignment != nil && lastAssignmentOutdated(wl, cq) {
	wl.LastAssignment = nil
	if logV := log.V(6); logV.Enabled() {

[tenzen-y]

/cherry-pick release-0.5

[k8s-infra-cherrypick-robot]

@tenzen-y: new pull request created: #1645

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

Why is this PR merged in spite of /hold?

Because the bot was not able to put the label on time.

[tenzen-y]

Why is this PR merged in spite of /hold?

Because the bot was not able to put the label on time.

It makes sense.