Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multikueue] Job live status update #1668

Merged
merged 9 commits into from
Feb 6, 2024
Merged

[multikueue] Job live status update #1668

merged 9 commits into from
Feb 6, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Jan 29, 2024 •
edited by k8s-ci-robot

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add live status updates for multikueue jobs

Which issue(s) this PR fixes:

Relates to #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?

MultiKueue: Add live status updates for multikueue JobSets

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 29, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 7a36502
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65c1fc05b89e4b00096d4220

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 29, 2024
mimowo
mimowo reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comment about the watch scope. I think we should have a label to make the filtering fast.

pkg/controller/admissionchecks/multikueue/multikueuecluster.go Show resolved Hide resolved
@mimowo mimowo mentioned this pull request Feb 1, 2024
Closed
3 tasks
mimowo
mimowo reviewed Feb 1, 2024
View reviewed changes
pkg/controller/admissionchecks/multikueue/workload.go Show resolved Hide resolved
test/e2e/multikueue/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/multikueue/e2e_test.go Show resolved Hide resolved
@trasc trasc force-pushed the multikueue-live-status-update branch from 606540b to 1bbdaf1 Compare February 1, 2024 12:57
@trasc
Copy link
Contributor Author

trasc commented Feb 1, 2024

/test pull-kueue-test-e2e-main-1-26

mimowo
mimowo reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, looking good overall, we need to have the label to restrict the watch for Jobs. This could be a follow up, or we wait for the GC PR.

@alculquicondor
Copy link
Contributor

is this for jobs or jobsets?

@tenzen-y
Copy link
Member

tenzen-y commented Feb 1, 2024 •
edited

is this for jobs or jobsets?

At first glance, this PR is for both job and jobset since this PR is extended job_adapter and jobset_adapter.

@trasc trasc force-pushed the multikueue-live-status-update branch from e344f81 to bf9b888 Compare February 2, 2024 08:22
mimowo
mimowo reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, just nits + we need to migrate to the origin label.

pkg/controller/admissionchecks/multikueue/multikueuecluster.go Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/workload.go Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold
for comments
Leaving LGTM to @mimowo

pkg/controller/admissionchecks/multikueue/batchjob_adapter.go Outdated
@@ -30,14 +31,20 @@ type batchJobAdapter struct{}

var _ jobAdapter = (*batchJobAdapter)(nil)

func (b *batchJobAdapter) CreateRemoteObject(ctx context.Context, localClient client.Client, remoteClient client.Client, key types.NamespacedName, workloadName string) error {
func (b *batchJobAdapter) SyncJob(ctx context.Context, localClient client.Client, remoteClient client.Client, key types.NamespacedName, workloadName string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment about what this SyncJob function does and does not do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is described at interface level, the batch job specifics are described inline.

pkg/controller/admissionchecks/multikueue/multikueuecluster.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/workload.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Show resolved Hide resolved
test/e2e/multikueue/e2e_test.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 5, 2024
@trasc trasc force-pushed the multikueue-live-status-update branch from f31b47b to 0999914 Compare February 6, 2024 07:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2024
mimowo
mimowo reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits / quesiton

pkg/controller/admissionchecks/multikueue/multikueuecluster.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/batchjob_adapter.go Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Show resolved Hide resolved
@mimowo
Copy link
Contributor

mimowo commented Feb 6, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e6285fce52db704a8f0fe411394096ed7562d7a5

@mimowo
Copy link
Contributor

mimowo commented Feb 6, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9959efd into kubernetes-sigs:main Feb 6, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Feb 6, 2024
@trasc trasc deleted the multikueue-live-status-update branch February 8, 2024 06:34
@alculquicondor
Copy link
Contributor

/release-note-edit

MultiKueue: Add live status updates for multikueue JobSets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mimowo mimowo mimowo left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trasc @alculquicondor @tenzen-y @k8s-ci-robot @mimowo