-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multikueue] Job live status update #1668
[multikueue] Job live status update #1668
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comment about the watch scope. I think we should have a label to make the filtering fast.
606540b
to
1bbdaf1
Compare
/test pull-kueue-test-e2e-main-1-26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, looking good overall, we need to have the label to restrict the watch for Jobs. This could be a follow up, or we wait for the GC PR.
is this for jobs or jobsets? |
At first glance, this PR is for both job and jobset since this PR is extended job_adapter and jobset_adapter. |
e344f81
to
bf9b888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM, just nits + we need to migrate to the origin label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
for comments
Leaving LGTM to @mimowo
@@ -30,14 +31,20 @@ type batchJobAdapter struct{} | |||
|
|||
var _ jobAdapter = (*batchJobAdapter)(nil) | |||
|
|||
func (b *batchJobAdapter) CreateRemoteObject(ctx context.Context, localClient client.Client, remoteClient client.Client, key types.NamespacedName, workloadName string) error { | |||
func (b *batchJobAdapter) SyncJob(ctx context.Context, localClient client.Client, remoteClient client.Client, key types.NamespacedName, workloadName string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment about what this SyncJob function does and does not do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is described at interface level, the batch job specifics are described inline.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f31b47b
to
0999914
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some nits / quesiton
/lgtm |
LGTM label has been added. Git tree hash: e6285fce52db704a8f0fe411394096ed7562d7a5
|
/hold cancel |
/release-note-edit
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add live status updates for multikueue jobs
Which issue(s) this PR fixes:
Relates to #693
Special notes for your reviewer:
Does this PR introduce a user-facing change?