-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a uniquely identifying selector based on recommended labels for Kueue deployment #1695
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Hi @astefanutti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally lgtm, some asks for explanations as I'm not that familiar with the helm scripts yet
/test pull-kueue-test-e2e-main-1-27 |
/test pull-kueue-test-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm
I left comments for some nits.
/approve
/retest |
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: da7d427c1e61473d95ef960c610b8dfd6c313c96
|
…ueue deployment (kubernetes-sigs#1695) * Use recommended labels and a uniquely identifying selector * update-helm script applies k8s recommended labels * Use kueue.labels as label selector in Helm ServiceMonitor chart * Add app.kubernetes.io/instance label back to Helm kueue.selectorLabels * Update config/components/visibility/service.yaml Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Update Makefile Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> --------- Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
I'm worried that this change can cause significant friction to upgrade. Should we consider a revert? Is anyone familiar with how other projects have achieved this change with minimal disruption? |
Your concern is right. Actually, the
@alculquicondor I'm curious about whether we can do a similar approach. |
Overall, that sounds good, but: at some point, we will have to update the Deployment object. And that will always be a breaking change. |
You're right.
That makes sense. |
So for now, let's revert the selector change and add the old and new labels? |
SGTM Just confirmation. After reverting this PR, we will create a new PR with manifests using new labels, right? |
Well, this PR has a few more changes. Is it easier to just manually undo the changes to the Deployment selector? Is this something you can take @tenzen-y ? |
The partial revert is not trivial. I think we should do a full revert #2246 (comment) |
I'm ok with completely reverting. |
* Restore control-plane label in kustomize templates * Restore control-plane label in helm template
Because we merged #1695 /release-note-edit
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR proposes to change the default label selector currently used by the Kueue deployment from:
to the following selector, that uses Kubernetes recommended labels to uniquely identify Kueue Pods:
Which issue(s) this PR fixes:
Fixes #1685
Special notes for your reviewer:
The script that updates the Helm charts has to be adapted to apply parameterised labels selectors.
Does this PR introduce a user-facing change?