-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement backoff re-queuing mechanism #1709
Implement backoff re-queuing mechanism #1709
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1f78bf3
to
fede9c9
Compare
6054a7d
to
b2022b0
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
4fe812d
to
37efbbf
Compare
Rebased |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Can you fix the verify? |
Sure. |
LGTM otherwise. |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave for a follow up to remove the stub. I don't think it's necessary, if we rework the unit tests.
/lgtm
LGTM label has been added. Git tree hash: 3f48edfa9fdae121b674d87983ed3aeae76ff5ab
|
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
I'm still working on #1709 (comment) and #1709 (comment). |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
/hold |
… pending Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
/hold cancel |
Let me try to rework the unit tests to avoid stubs as a follow-up. |
/lgtm |
LGTM label has been added. Git tree hash: 7113c7a278f1978076e5616e526705aa6ca25257
|
/release-note-edit
|
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
I implemented a backoff re-queue mechanism when a workload meets an Eviction with PodsReadyTimout reason.
Which issue(s) this PR fixes:
Part-of #1282
Special notes for your reviewer:
KEP-1282: https://github.com/kubernetes-sigs/kueue/blob/3cd0da66f57dc90f9d5e631b218f7a374204d07d/keps/1282-pods-ready-requeue-strategy/README.md
Does this PR introduce a user-facing change?