Don't deploy visibility by default

[trasc]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Don't deploy visibility by default to avoid

E0216 16:57:43.448953  907490 memcache.go:287] couldn't get resource list for visibility.kueue.x-k8s.io/v1alpha1: the server is currently unable to handle the request
E0216 16:57:43.451994  907490 memcache.go:121] couldn't get resource list for visibility.kueue.x-k8s.io/v1alpha1: the server is currently unable to handle the request

in older k8s versions.

Which issue(s) this PR fixes:

Fixes #1519

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kueue visibility API is no longer installed by default. Users can install it via helm or applying the visibility-api.yaml artifact.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	e24adfe
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65d615bd2eddf400083b2563

[mimowo]

LGTM, just one more nit
/assign @tenzen-y

[tenzen-y]

Basically lgtm. I confirmed that this should work fine in the following:

# The default values.yaml
$ helm template ./charts/kueue --values ./charts/kueue/values.yaml | grep APIService
# No output

# The default values.yaml with the `VisibilityOnDemand`.
# ...
# controllerManager:
#   featureGates:
#     - name: VisibilityOnDemand
#       enabled: true
# ...
$ helm template ./charts/kueue --values ./charts/kueue/values.yaml | grep -A2 APIService
kind: APIService
metadata:
  name: v1alpha1.visibility.kueue.x-k8s.io

[tenzen-y]

I left lgtm on @mimowo
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tenzen-y]

/cherry-pick release-0.6

[k8s-infra-cherrypick-robot]

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[trasc]

/test all

[tenzen-y]

/test all

Prow EKS cluster seems to be down.
https://kubernetes.slack.com/archives/CCK68P2Q2/p1708527057849979

[trasc]

/test all

[mimowo]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: eb12c7c82f19b112c851e3763d4be211594c082c

[k8s-infra-cherrypick-robot]

@tenzen-y: new pull request created: #1764

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

/release-note-edit

Kueue visibility API is no longer installed by default. Users can install it via helm or applying the visibility-api.yaml artifact.