-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't deploy visibility by default #1746
Don't deploy visibility by default #1746
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one more nit
/assign @tenzen-y
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically lgtm. I confirmed that this should work fine in the following:
# The default values.yaml
$ helm template ./charts/kueue --values ./charts/kueue/values.yaml | grep APIService
# No output
# The default values.yaml with the `VisibilityOnDemand`.
# ...
# controllerManager:
# featureGates:
# - name: VisibilityOnDemand
# enabled: true
# ...
$ helm template ./charts/kueue --values ./charts/kueue/values.yaml | grep -A2 APIService
kind: APIService
metadata:
name: v1alpha1.visibility.kueue.x-k8s.io
I left lgtm on @mimowo |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.6 |
@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
Prow EKS cluster seems to be down. |
/test all |
/lgtm |
LGTM label has been added. Git tree hash: eb12c7c82f19b112c851e3763d4be211594c082c
|
@tenzen-y: new pull request created: #1764 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/release-note-edit
|
* Don't deploy visibility by default * Review Remarks * Review Remarks * Review Remarks
What type of PR is this?
/kind bug
What this PR does / why we need it:
Don't deploy visibility by default to avoid
in older k8s versions.
Which issue(s) this PR fixes:
Fixes #1519
Special notes for your reviewer:
Does this PR introduce a user-facing change?