Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop kueue.x-k8s.io/parent-workload in favor of a object ownership based approach. #1747

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Drop kueue.x-k8s.io/parent-workload in favor of a object ownership based approach. #1747

merged 2 commits into from
Feb 19, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Feb 16, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Drop the usage of kueue.x-k8s.io/parent-workload annotation in favor of an object ownership based approach.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Dropped the usage of `kueue.x-k8s.io/parent-workload` annotation  in favor of an object ownership based approach.

@trasc
Drop kueue.x-k8s.io/parent-workload
ef81d9c 
Drop `kueue.x-k8s.io/parent-workload` in favor of a object
ownership based approach.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 16, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 16, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 16, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 2cdaf22
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65d337e5d0efff00083a8a04

@trasc trasc mentioned this pull request Feb 16, 2024
Merged
@alculquicondor
Copy link
Contributor

/cc

@tenzen-y
Copy link
Member

@trasc Could you share some context for this?

@tenzen-y
Copy link
Member

I was not sure why this improvement is needed.

@tenzen-y
Copy link
Member

@trasc Could you share some context for this?

Oh, I found a context myself here: #1732 (comment)

alculquicondor
alculquicondor reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much less code, so I'm all in for it :)

pkg/controller/core/indexer/indexer.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/reconciler.go Show resolved Hide resolved
test/integration/controller/jobs/mpijob/mpijob_controller_test.go Show resolved Hide resolved
mimowo
mimowo reviewed Feb 16, 2024
View reviewed changes
pkg/controller/core/indexer/indexer.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/reconciler.go Show resolved Hide resolved
tenzen-y
tenzen-y reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, lgtm, but I think we need to add the proper release note since any system might depend on this annotation (although my company doesn't depend on this annotation 🙃 ).

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 19, 2024
@trasc
Copy link
Contributor Author

trasc commented Feb 19, 2024

Generally, lgtm, but I think we need to add the proper release note since any system might depend on this annotation (although my company doesn't depend on this annotation 🙃 ).

Updated

mimowo
mimowo reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb765ea025023830ea5155bd0ed026dae0fd0678

alculquicondor
alculquicondor reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit bd2d09c into kubernetes-sigs:main Feb 19, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Feb 19, 2024
@trasc trasc deleted the no-parentwl-annotation branch February 20, 2024 07:03
dimakis pushed a commit to dimakis/kueue that referenced this pull request Feb 20, 2024
@trasc @dimakis
Drop kueue.x-k8s.io/parent-workload in favor of a object ownership …
9003837 
…based approach. (kubernetes-sigs#1747)

* Drop `kueue.x-k8s.io/parent-workload`

Drop `kueue.x-k8s.io/parent-workload` in favor of a object
ownership based approach.

* Review Remarks
@astefanutti astefanutti mentioned this pull request Mar 14, 2024
Merged
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@trasc @vsoch
Drop kueue.x-k8s.io/parent-workload in favor of a object ownership …
692ef12 
…based approach. (kubernetes-sigs#1747)

* Drop `kueue.x-k8s.io/parent-workload`

Drop `kueue.x-k8s.io/parent-workload` in favor of a object
ownership based approach.

* Review Remarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mimowo mimowo mimowo left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trasc @alculquicondor @tenzen-y @k8s-ci-robot @mimowo