-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix number of reconcilers for Pod integration #1835
Fix number of reconcilers for Pod integration #1835
Conversation
Change-Id: If8f430731a6967a361d0f5172ed408f57a0687bc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/lgtm |
LGTM label has been added. Git tree hash: 98f059704ecd982913c6eabcd1f8b211a3559222
|
/cherry-pick release-0.6 |
@alculquicondor: new pull request created: #1837 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Change-Id: If8f430731a6967a361d0f5172ed408f57a0687bc
/release-note-edit
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
There were 2 problems:
For
, which controller-runtime uses to map to groupKindConcurrency.Pod
, notPod.
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Thanks to @gabesaba for spotting the problem.
It's not easy to test this issue, but I did a manual run to verify the number of reconcilers.
Does this PR introduce a user-facing change?