-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #1820: Do not make API calls when the workload already has condition #1845
Automated cherry pick of #1820: Do not make API calls when the workload already has condition #1845
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign @tenzen-y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/release-note-edit
Avoid API calls for admission attempts when Workload already has condition Admitted=false
Makefile
Outdated
@@ -190,14 +190,12 @@ run-test-e2e-%: K8S_VERSION = $(@:run-test-e2e-%=%) | |||
run-test-e2e-%: FORCE | |||
@echo Running e2e for k8s ${K8S_VERSION} | |||
E2E_KIND_VERSION="kindest/node:v$(K8S_VERSION)" KIND_CLUSTER_NAME=$(KIND_CLUSTER_NAME) CREATE_KIND_CLUSTER=$(CREATE_KIND_CLUSTER) ARTIFACTS="$(ARTIFACTS)/$@" IMAGE_TAG=$(IMAGE_TAG) GINKGO_ARGS="$(GINKGO_ARGS)" ./hack/e2e-test.sh | |||
@$(call clean-manifests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these changes?
@alculquicondor Should we drop this commit: 036dd01? |
…d=false Change-Id: Ib10c1874bfb3f5810f83d751e4d80ca6eb031bfa
d333903
to
1695668
Compare
It looks like my branch was corrupted, sorry about that. |
No problems :) |
/release-note-edit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 302efd9a525caa449584ff29e2d436ce94cd752e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup |
Cherry pick of #1820 on release-0.6.
#1820: Do not make API calls when the workload already has condition
For details on the cherry pick process, see the cherry pick requests page.