-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unnecessary preemptions when candidates have the same timestamp #1875
Avoid unnecessary preemptions when candidates have the same timestamp #1875
Conversation
Change-Id: I68155a467880059c65deb75b00939b14551924cd
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @yaroslava-serdiuk |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
LGTM label has been added. Git tree hash: 7cb5e46dbb00b317e6e526b7a8f18e913baf9bbf
|
/cherry-pick release-0.6 |
@alculquicondor: new pull request created: #1880 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…kubernetes-sigs#1875) Change-Id: I68155a467880059c65deb75b00939b14551924cd
What type of PR is this?
/kind bug
What this PR does / why we need it:
When there are multiple workloads waiting for preemption and multiple candidates with the same timestamp, it was possible that all these candidates would be preempted across a few admission attempts.
This can be mitigated by using the information about the workloads pending preemption and introducing stable sorting.
In this fix, I'm using the UID as an arbitrary unpredictable key to do stable sorting.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?