Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow configuration of ipFamilyPolicy #1933

Merged
merged 3 commits into from
Apr 5, 2024
Merged

allow configuration of ipFamilyPolicy #1933

merged 3 commits into from
Apr 5, 2024

Conversation

dongjiang1989
Copy link
Contributor

@dongjiang1989 dongjiang1989 commented Mar 31, 2024 •
edited by k8s-ci-robot

What type of PR is this?

/kind documentation
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

add support allow configuration of ipFamilyPolicy for ipDualStack kubernetes cluster

Does this PR introduce a user-facing change?

Helm: Allow configuration of `ipFamilyPolicy` for ipDualStack kubernetes cluster

@dongjiang1989
add ip dualstack
147fa93 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 31, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dongjiang1989!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 31, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 635e632
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/660cc7644a14010008ce34d1

@dongjiang1989
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@dongjiang1989: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trasc
Copy link
Contributor

trasc commented Apr 1, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2024
@trasc
Copy link
Contributor

trasc commented Apr 1, 2024

@dongjiang1989 the verify fails because charts/kueue/templates/webhook/service.yaml is generated by /hack/update-helm.sh you should also change that.

You can run make verify locally to check how it works before pushing.

@dongjiang1989
fix make verify
e5294a2 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2024
@dongjiang1989
Copy link
Contributor Author

dongjiang1989 commented Apr 2, 2024 •
edited

@dongjiang1989 the verify fails because charts/kueue/templates/webhook/service.yaml is generated by /hack/update-helm.sh you should also change that.

You can run make verify locally to check how it works before pushing.

Thanks. Fixed it. Please recheck @trasc

trasc
trasc reviewed Apr 2, 2024
View reviewed changes
hack/update-helm.sh Outdated Show resolved Hide resolved
@dongjiang1989
fix by code review
635e632 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
tenzen-y
tenzen-y reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Leave lgtm on @trasc.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjiang1989, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@tenzen-y
Copy link
Member

tenzen-y commented Apr 3, 2024

/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 3, 2024
@tenzen-y
Copy link
Member

tenzen-y commented Apr 3, 2024

Oops, this is actually user facing.

/release-note-edit

add support allow configuration of `ipFamilyPolicy` for ipDualStack kubernetes cluster

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 3, 2024
@tenzen-y
Copy link
Member

tenzen-y commented Apr 3, 2024

/remove-kind documentation

@k8s-ci-robot k8s-ci-robot removed the kind/documentation Categorizes issue or PR as related to documentation. label Apr 3, 2024
trasc
trasc reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 084b36e3539f544b10cac8caffa081f9be2009bd

@k8s-ci-robot k8s-ci-robot merged commit 93abdd7 into kubernetes-sigs:main Apr 5, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Apr 5, 2024
@dongjiang1989 dongjiang1989 deleted the ip-family-policy branch April 6, 2024 23:18
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@dongjiang1989 @vsoch
allow configuration of ipFamilyPolicy (kubernetes-sigs#1933)
2e19cf8 
* add ip dualstack

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

* fix make verify

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

* fix by code review

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

---------

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@alculquicondor
Copy link
Contributor

/release-note-edit

Helm: Allow configuration of `ipFamilyPolicy` for ipDualStack kubernetes cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasc trasc trasc left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dongjiang1989 @k8s-ci-robot @trasc @tenzen-y @alculquicondor