Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ObservedGeneration in conditions #1939

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Set ObservedGeneration in conditions #1939

merged 3 commits into from
Apr 16, 2024

Conversation

vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented Apr 2, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Sets the .observedGeneration in conditions based on .metadata.generation, in all Kueue objects.

Which issue(s) this PR fixes:

Fixes #1750

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds ObservedGeneration in conditions

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @vladikkuzn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 2, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 2, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit b3cccf7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/661e14b1088c3f0008ce0685

@vladikkuzn
Copy link
Contributor Author

/cc @trasc

@k8s-ci-robot k8s-ci-robot requested a review from trasc April 2, 2024 17:33
@trasc
Copy link
Contributor

trasc commented Apr 2, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2024
@vladikkuzn vladikkuzn force-pushed the set-observedGeneration-in-conditions branch 3 times, most recently from a139a91 to 561f339 Compare April 3, 2024 22:29
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 3, 2024
@vladikkuzn vladikkuzn force-pushed the set-observedGeneration-in-conditions branch from 561f339 to b86dc0b Compare April 3, 2024 22:36
@vladikkuzn
Copy link
Contributor Author

/retest

@vladikkuzn vladikkuzn force-pushed the set-observedGeneration-in-conditions branch from b86dc0b to c141bfe Compare April 3, 2024 22:43
@vladikkuzn
Copy link
Contributor Author

/retest

@vladikkuzn vladikkuzn force-pushed the set-observedGeneration-in-conditions branch from c141bfe to cc4bb13 Compare April 3, 2024 23:09
@vladikkuzn
Copy link
Contributor Author

/retest

@vladikkuzn vladikkuzn marked this pull request as ready for review April 4, 2024 07:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2024
@alculquicondor
Copy link
Contributor

/assign @trasc

trasc
trasc reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit.

Otherwise LGTM.

pkg/controller/jobs/raycluster/raycluster_controller_test.go Show resolved Hide resolved
@vladikkuzn vladikkuzn force-pushed the set-observedGeneration-in-conditions branch from a4c271b to b3a1beb Compare April 15, 2024 03:05
@vladikkuzn vladikkuzn requested a review from trasc April 15, 2024 03:06
trasc
trasc reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. just two nits.

pkg/controller/jobs/mpijob/mpijob_controller_test.go Outdated Show resolved Hide resolved
pkg/controller/jobs/rayjob/rayjob_controller_test.go Outdated Show resolved Hide resolved
@vladikkuzn vladikkuzn force-pushed the set-observedGeneration-in-conditions branch from b3a1beb to d3b0f43 Compare April 15, 2024 10:10
mimowo
mimowo reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm overall, couple of nits

pkg/controller/core/localqueue_controller.go Outdated Show resolved Hide resolved
pkg/controller/core/localqueue_controller.go Outdated Show resolved Hide resolved
pkg/controller/core/localqueue_controller_test.go Show resolved Hide resolved
pkg/controller/jobframework/interface.go Outdated Show resolved Hide resolved
pkg/controller/jobs/raycluster/raycluster_controller_test.go Show resolved Hide resolved
pkg/controller/jobs/mpijob/mpijob_controller_test.go Outdated Show resolved Hide resolved
@vladikkuzn vladikkuzn force-pushed the set-observedGeneration-in-conditions branch from d3b0f43 to 1bc9eaa Compare April 15, 2024 13:28
@mimowo
Copy link
Contributor

mimowo commented Apr 15, 2024

LGTM, last pending nit from me

@alculquicondor
Copy link
Contributor

I don't remember if we added more conditions since you started this PR. Could you rebase and do a quick check?

@vladikkuzn vladikkuzn force-pushed the set-observedGeneration-in-conditions branch from 1bc9eaa to 6b54082 Compare April 16, 2024 05:31
@vladikkuzn
Set ObservedGeneration in conditions and update tests
821500a
@vladikkuzn
* Update unit tests to check ObservedGeneration in conditions
b0f4197 
* Reorder imports
* Merge IgnoreConditionTimestampsAndObservedGeneration
@vladikkuzn
* Revert pkg/scheduler/scheduler_test.go
b3cccf7 
* Unit tests for ObservedGeneration in pkg/**
* Ignore ObservedGeneration in integration tests
@vladikkuzn
Copy link
Contributor Author

vladikkuzn commented Apr 16, 2024 •
edited

There seems to be no more places where obs generation is not set
ps. Changes from this PR are covered

@vladikkuzn vladikkuzn force-pushed the set-observedGeneration-in-conditions branch from 6b54082 to b3cccf7 Compare April 16, 2024 06:03
@mimowo
Copy link
Contributor

mimowo commented Apr 16, 2024

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 41d3c62edfd2f2c9e4ac897633cdc74c591d131a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 82753a1 into kubernetes-sigs:main Apr 16, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Apr 16, 2024
@vladikkuzn vladikkuzn deleted the set-observedGeneration-in-conditions branch April 16, 2024 06:50
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@vladikkuzn @vsoch
Set ObservedGeneration in conditions (kubernetes-sigs#1939)
470fc3f 
* Set ObservedGeneration in conditions and update tests

* * Update unit tests to check ObservedGeneration in conditions
* Reorder imports
* Merge IgnoreConditionTimestampsAndObservedGeneration

* * Revert pkg/scheduler/scheduler_test.go
* Unit tests for ObservedGeneration in pkg/**
* Ignore ObservedGeneration in integration tests
@vladikkuzn vladikkuzn mentioned this pull request Apr 26, 2024
Closed
11 tasks
@alculquicondor
Copy link
Contributor

/remove-kind cleanup
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@trasc trasc trasc left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@kerthcet kerthcet Awaiting requested review from kerthcet

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@mimowo mimowo

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Set observedGeneration in Conditions
5 participants
@vladikkuzn @k8s-ci-robot @trasc @alculquicondor @mimowo