Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index PodGroupName #1952

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Index PodGroupName #1952

merged 1 commit into from
Apr 5, 2024

Conversation

gabesaba
Copy link
Contributor

@gabesaba gabesaba commented Apr 5, 2024 •
edited by k8s-ci-robot

What type of PR is this?

What this PR does / why we need it:

This is a hotspot when there are many pods within a namespace. Compare a 60s CPU sample, pivoting around client.List

Before:
before
After
after

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Pod Integration: Improve performance

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @gabesaba. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 5, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 5, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit bc9bdf9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/661041e6073be3000986ee64

@alculquicondor
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2024
alculquicondor
alculquicondor reviewed Apr 5, 2024
View reviewed changes
pkg/controller/jobs/pod/indexer.go Outdated
if labelValue, labelExists := pod.GetLabels()[GroupNameLabel]; labelExists {
return []string{labelValue}
}
return []string{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return []string{}
return nil

pkg/controller/jobs/pod/indexer.go Outdated
return nil
}

if labelValue, labelExists := pod.GetLabels()[GroupNameLabel]; labelExists {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
if labelValue, labelExists := pod.GetLabels()[GroupNameLabel]; labelExists {
if labelValue, exists := pod.GetLabels()[GroupNameLabel]; exists {

variable name length should be proportional to the scope of the variable. This variable's scope is one line :)

pkg/controller/jobs/pod/indexer.go
@@ -0,0 +1,28 @@
package pod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add copyright note

pkg/controller/jobs/pod/pod_controller.go Outdated
@@ -477,7 +477,13 @@ func (p *Pod) Stop(ctx context.Context, c client.Client, _ []podset.PodSetInfo,
}

func SetupIndexes(ctx context.Context, indexer client.FieldIndexer) error {
return jobframework.SetupWorkloadOwnerIndex(ctx, indexer, gvk)
if err := SetupPodGroupNameIndex(ctx, indexer); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Suggested change
if err := SetupPodGroupNameIndex(ctx, indexer); err != nil {
if err := indexer.IndexField(ctx, &corev1.Pod{}, PodGroupNameCacheKey, IndexPodGroupName); err != nil {

Prefer less indirection for a one-liner

@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac2059a3aa801b35d21df04b59ce98595eb6566c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, gabesaba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9b833df into kubernetes-sigs:main Apr 5, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Apr 5, 2024
@alculquicondor
Copy link
Contributor

/cherry-pick release-0.6

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 5, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@alculquicondor: new pull request created: #1953

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 5, 2024
@gabesaba gabesaba deleted the index-pod-group-name branch April 10, 2024 14:24
@gabesaba gabesaba mentioned this pull request Apr 11, 2024
Merged
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@gabesaba @vsoch
Index PodGroupName (kubernetes-sigs#1952)
1b93d4f
@mimowo mimowo mentioned this pull request Apr 26, 2024
Merged
@alculquicondor
Copy link
Contributor

/remove-kind cleanup
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 8, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

Pod Integration: Improve performance

@gabesaba gabesaba mentioned this pull request Jun 10, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gabesaba @k8s-ci-robot @alculquicondor @k8s-infra-cherrypick-robot