-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-admitted workloads with QuotaReserved condition are shown as Admitted by kubectl #1991
Non-admitted workloads with QuotaReserved condition are shown as Admitted by kubectl #1991
Conversation
Hi @vladikkuzn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign |
* Add "Admitted" printed column
b159904
to
9bd59b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm.
/release-note-edit |
/release-note-edit```
|
/release-note-edit ```
|
Ok, not sure what I do wrong :) Please update the release note manually |
/release-note-edit
|
@vladikkuzn: You must be an org member to edit the release note. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Rename "Reserving in" to "Reserved in"
Made updates to the docs, thanks for notifying @tenzen-y |
Thanks! /lgtm |
LGTM label has been added. Git tree hash: c4884685884ab7ac35668a19ce6c528a610d8386
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, vladikkuzn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.6 |
@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@alculquicondor: #1991 failed to apply on top of branch "release-0.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tenzen-y what's your sentiment? should we attempt a manual cherry-pick? |
I think that cherry-picking would be worth it. |
@vladikkuzn could you produce a manual cherry-pick? |
…in" printed column * (#2014) * * Rename "Admitted by" to "Reserving in" printed column * Add "Admitted" printed column * * Output Admitted column without -wide * * Remove priority=0 as it's default * * Documentation update * Rename "Reserving in" to "Reserved in"
/remove-kind cleanup |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
kubectl get workload
kubectl get workload
Which issue(s) this PR fixes:
Fixes #1790
Special notes for your reviewer:
Does this PR introduce a user-facing change?