Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a Failed condition in Workloads #2026

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Include a Failed condition in Workloads #2026

merged 4 commits into from
Apr 26, 2024

Conversation

vladikkuzn
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Replaces workload finished reason with succeeded and failed reasons

Which issue(s) this PR fixes:

Fixes #1982

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Workload finished reason replaced with succeeded and failed reasons

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 21, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @vladikkuzn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 21, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 21, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 086fa8a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/662b81e35feae9000890fb8c

@vladikkuzn vladikkuzn force-pushed the Include-a-Failed-condition-in-Workloads branch from 1a939f8 to d10d285 Compare April 22, 2024 07:17
@trasc
Copy link
Contributor

trasc commented Apr 22, 2024

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2024
@vladikkuzn vladikkuzn force-pushed the Include-a-Failed-condition-in-Workloads branch from d10d285 to 7726cc2 Compare April 22, 2024 09:22
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2024
@vladikkuzn
Copy link
Contributor Author

/retest

@vladikkuzn vladikkuzn marked this pull request as ready for review April 22, 2024 10:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024
trasc
trasc reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits. otherwise LGTM.
/cc @alculquicondor

apis/kueue/v1beta1/workload_types.go Outdated Show resolved Hide resolved
apis/kueue/v1beta1/workload_types.go Outdated Show resolved Hide resolved
apis/kueue/v1beta1/workload_types.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/interface.go Outdated Show resolved Hide resolved
@vladikkuzn vladikkuzn force-pushed the Include-a-Failed-condition-in-Workloads branch from 887402f to 7277514 Compare April 24, 2024 06:43
trasc
trasc reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7522ee9a056bb4614885f48e4fb918caf43f6f77

alculquicondor
alculquicondor reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go one step further :)

pkg/controller/jobs/job/job_controller.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot requested a review from trasc April 25, 2024 20:33
@vladikkuzn vladikkuzn mentioned this pull request Apr 26, 2024
Closed
11 tasks
@vladikkuzn vladikkuzn force-pushed the Include-a-Failed-condition-in-Workloads branch from eb3231e to 07bfa93 Compare April 26, 2024 07:38
@mimowo
Copy link
Contributor

mimowo commented Apr 26, 2024

You also need to adapt the MK tests, other than that LGTM. Thanks!

@vladikkuzn
Copy link
Contributor Author

/assign

@vladikkuzn vladikkuzn force-pushed the Include-a-Failed-condition-in-Workloads branch from 07bfa93 to bd2fef1 Compare April 26, 2024 10:08
@vladikkuzn
* Replace workload finished reason with succeeded and failed reasons
c241bb2
@vladikkuzn
* Replace workload finished interface `Finished() (metav1.Condition, …
29845ab 
…bool)` with `Finished() (reason, message string, finished bool)`
@vladikkuzn
* Update comments for WorkloadFinishedReason in workload_types.go
5976fb0 
* Update Finished() (message string, success, finished bool) to return success instead of reason
@vladikkuzn vladikkuzn force-pushed the Include-a-Failed-condition-in-Workloads branch from bd2fef1 to c78cc71 Compare April 26, 2024 10:09
@vladikkuzn vladikkuzn force-pushed the Include-a-Failed-condition-in-Workloads branch from c78cc71 to 086fa8a Compare April 26, 2024 10:28
@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5ad01bdb67a1b8fc945d627415ed8a2175a5d174

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9d77f2f into kubernetes-sigs:main Apr 26, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Apr 26, 2024
@vladikkuzn vladikkuzn mentioned this pull request Apr 28, 2024
Merged
@mimowo mimowo mentioned this pull request Jul 30, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@trasc trasc Awaiting requested review from trasc

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

@vladikkuzn vladikkuzn

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Include a Failed condition in Workloads
5 participants
@vladikkuzn @k8s-ci-robot @trasc @mimowo @alculquicondor