-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kueuectl] Create Local Queue #2027
[kueuectl] Create Local Queue #2027
Conversation
Hi @mbobrovskyi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/ok-to-test |
/ok-to-test |
/test all |
/cc @IrvingMg |
@trasc: GitHub didn't allow me to request PR reviews from the following users: IrvingMg, vladikkuzn. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vladikkuzn @IrvingMg please have a look as well , for now we mainly want to have a structure established.
Without going to too much details it looks good to me.
Overall looks good, except that one thing with cmd inside cmd |
/lgtm |
/approve @tenzen-y anything to add? |
|
||
util.AddDryRunFlag(cmd) | ||
cmd.Flags().StringVarP(&o.UserSpecifiedClusterQueue, "clusterqueue", "c", "", | ||
"The cluster queue name which will be associated with the local queue (required).") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to specify namespace since the clusterQueue is the cluster scoped resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you!
/lgtm
/approve
LGTM label has been added. Git tree hash: 5367c21394de5b237545f4be4e8e054707fcd75b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mbobrovskyi, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alculquicondor @tenzen-y can we merge it to master? |
Not sure why this is stuck for 12h /retest |
The job is actually stuck 🤔 The tests themselves seem to have finished, but something about the post-processing is stuck. Maybe it's related to #2097 I'm not sure how to get it unstuck. Can you try just squashing all the commits? |
ae9cad0
to
4bdcdcf
Compare
/test pull-kueue-test-integration-main |
4bdcdcf
to
87c54d6
Compare
/test pull-kueue-test-integration-main |
/lgtm |
LGTM label has been added. Git tree hash: 0eafaff0c4226b3f6199a6c453496b7cac2c254c
|
/release-note-edit
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?