Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MultiKueue] Default managedBy for ClusterQueues configured to use MultiKueue AC #2048

Merged
merged 7 commits into from
May 9, 2024
Merged

[MultiKueue] Default managedBy for ClusterQueues configured to use MultiKueue AC #2048

merged 7 commits into from
May 9, 2024

Conversation

vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented Apr 24, 2024 •
edited by k8s-ci-robot

What type of PR is this?

/kind feature

What this PR does / why we need it:

Sets jobSet's ManagedBy field by default if it's managed by MultiKueue

Which issue(s) this PR fixes:

Fixes #2022

Special notes for your reviewer:

Does this PR introduce a user-facing change?

MultiKueue: Add the `managedBy` field to JobSets assigned to a ClusterQueue configured for MultiKueue

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @vladikkuzn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit a171146
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/663cf6648d9ea50008a21470
😎 Deploy Preview https://deploy-preview-2048--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vladikkuzn
Copy link
Contributor Author

/cc @trasc

@k8s-ci-robot k8s-ci-robot requested a review from trasc April 24, 2024 07:12
@vladikkuzn
Copy link
Contributor Author

/assign @trasc

@trasc
Copy link
Contributor

trasc commented Apr 24, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2024
@vladikkuzn
Copy link
Contributor Author

/retest

@vladikkuzn vladikkuzn marked this pull request as ready for review April 25, 2024 19:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@alculquicondor
Copy link
Contributor

/assign @mimowo

trasc
trasc reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b2331f5ea5d38361d828bd3c53210963499ec79

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot k8s-ci-robot requested review from mimowo and trasc May 8, 2024 20:01
tenzen-y
tenzen-y reviewed May 9, 2024
View reviewed changes
pkg/cache/cache.go Outdated Show resolved Hide resolved
pkg/controller/jobs/jobset/jobset_webhook.go Show resolved Hide resolved
pkg/controller/jobs/jobset/jobset_webhook.go Show resolved Hide resolved
pkg/controller/jobs/jobset/jobset_webhook.go Outdated Show resolved Hide resolved
@mimowo mimowo mentioned this pull request May 9, 2024
Merged
tenzen-y
tenzen-y reviewed May 9, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

Leaving lgtm on @mimowo

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, tenzen-y, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@vladikkuzn
* Remove Cache.ClusterQueue
a171146 
* Return nil instead of break
* Doc update
@mimowo
Copy link
Contributor

mimowo commented May 9, 2024

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 91d24b27c1ac2773c09c8b4754ea9ca5c39f3841

@k8s-ci-robot k8s-ci-robot merged commit e9c2f3f into kubernetes-sigs:main May 9, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 9, 2024
@vladikkuzn vladikkuzn deleted the job-set-default-managed-by branch May 9, 2024 16:32
@alculquicondor
Copy link
Contributor

/release-note-edit

MultiKueue: Add the `managedBy` field to JobSets assigned to a ClusterQueue configured for MultiKueue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@mimowo mimowo Awaiting requested review from mimowo

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

@mimowo mimowo

@vladikkuzn vladikkuzn

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

[MultiKueue] Default managedBy for ClusterQueues configured to use MultiKueue AC
6 participants
@vladikkuzn @k8s-ci-robot @trasc @alculquicondor @mimowo @tenzen-y