Added an option to control processing jobs with no queue name set #205

ahg-g · 2022-04-11T18:22:21Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds an internal flag to control whether or not the job-controller reconciles jobs with no queue name set; by default those jobs are not processed.

This is important so users are not surprised that their existing running jobs get suspended when they first try Kueue.

This flag will be exposed to be configurable via ComponentConfig once we add it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

k8s-ci-robot · 2022-04-11T18:22:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ahg-g · 2022-04-11T18:22:48Z

/hold

alculquicondor · 2022-04-11T18:38:32Z

pkg/controller/workload/job/job_controller.go

@@ -104,6 +133,11 @@ func (r *JobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R

 	log := ctrl.LoggerFrom(ctx).WithValues("job", klog.KObj(&job))
 	ctx = ctrl.LoggerInto(ctx, log)
+	if queueName(&job) == "" && !r.processJobsWithoutQueueName {
+		log.V(2).Info(fmt.Sprintf("%s annotation is not set, ignoring the job", constants.QueueAnnotation))


alculquicondor · 2022-04-11T18:43:36Z

test/integration/controller/job/job_controller_test.go

@@ -221,3 +244,38 @@ var _ = ginkgo.Describe("Job controller", func() {
 		}, framework.Timeout, framework.Interval).Should(gomega.BeTrue())
 	})
 })
+
+var _ = ginkgo.Describe("Job controller for workloads with no queue set", func() {


nit: I would use a single ginkgo.Describe with two ginkgo.Context, because you are describing the same controller.

the indentation is too much for me :)

alculquicondor · 2022-04-11T18:48:34Z

test/integration/controller/job/job_controller_test.go

+		fwk.Teardown()
+	})
+	ginkgo.It("Should reconcile jobs only when queue is set", func() {
+		ginkgo.By("checking the job gets suspended when created unsuspended")


Did you forget a line for this?

alculquicondor · 2022-04-11T19:04:18Z

Wait, I see the option, but I don't see the command line flag for it.

…e name set; by default those jobs are not processed

ahg-g · 2022-04-11T20:26:57Z

Wait, I see the option, but I don't see the command line flag for it.

No command-line flag, this is an option in the controller that we will expose via Component Config. I don't want to add a flag just so we deprecate it right away. I will send a PR after this one for CC, it is not that complicated.

alculquicondor

/lgtm

ahg-g · 2022-04-11T21:05:06Z

/hold cancel

kerthcet · 2022-04-12T01:38:05Z

pkg/controller/workload/job/job_controller.go

@@ -104,6 +133,11 @@ func (r *JobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R

 	log := ctrl.LoggerFrom(ctx).WithValues("job", klog.KObj(&job))
 	ctx = ctrl.LoggerInto(ctx, log)
+	if queueName(&job) == "" && !r.processJobsWithoutQueueName {


Q: Should this be queueName(&job) || "" && !r.processJobsWithoutQueueName, if users don't set the queue name, we do not have a default queue name for them now IIRC.

Can you clarify again the question? this basically says if r.processJobsWithoutQueueName=false, then don't manage jobs that don't set the queue-name.

A default queue name can be added, but it needs to be set via a webhook at job creation time if desired.

Can you clarify again the question? this basically says if r.processJobsWithoutQueueName=false, then don't manage jobs that don't set the queue-name.

I mean whether we should only check r.processJobsWithoutQueueName here and if queueName not set, we will add a default queue name like default automatically in ConstructWorkloadFor. But this means we should have default queue and default cq in initialization.

The problem we are trying to solve here is not that the queue is missing per se; see #63 (comment)

basically we don't want to miss up with potentially existing jobs when kueue is first installed.

moved discussion here #208

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2022

k8s-ci-robot requested review from ArangoGutierrez and denkensk April 11, 2022 18:22

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2022

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2022

ahg-g force-pushed the ahg-kueue branch from a7f58da to b7c1514 Compare April 11, 2022 18:26

ahg-g mentioned this pull request Apr 11, 2022

[Umbrella] ☂️ Requirements for release 0.1.0 #63

Closed

14 tasks

alculquicondor reviewed Apr 11, 2022

View reviewed changes

Added a flag to control whether or not to reconcile jobs with no queu…

0c2c7b0

…e name set; by default those jobs are not processed

ahg-g force-pushed the ahg-kueue branch from b7c1514 to 0c2c7b0 Compare April 11, 2022 20:25

ahg-g changed the title ~~Added a flag to control processing jobs with no queue name set~~ Added an option to control processing jobs with no queue name set Apr 11, 2022

alculquicondor reviewed Apr 11, 2022

View reviewed changes

k8s-ci-robot assigned alculquicondor Apr 11, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2022

k8s-ci-robot merged commit 9e87558 into kubernetes-sigs:main Apr 11, 2022

kerthcet reviewed Apr 12, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added an option to control processing jobs with no queue name set #205

Added an option to control processing jobs with no queue name set #205

ahg-g commented Apr 11, 2022

k8s-ci-robot commented Apr 11, 2022

ahg-g commented Apr 11, 2022

alculquicondor Apr 11, 2022

ahg-g Apr 11, 2022

alculquicondor Apr 11, 2022

ahg-g Apr 11, 2022

alculquicondor Apr 11, 2022

ahg-g Apr 11, 2022

alculquicondor commented Apr 11, 2022

ahg-g commented Apr 11, 2022

alculquicondor left a comment

ahg-g commented Apr 11, 2022

kerthcet Apr 12, 2022

ahg-g Apr 12, 2022

ahg-g Apr 12, 2022

kerthcet Apr 12, 2022 •

edited

Loading

ahg-g Apr 12, 2022

kerthcet Apr 12, 2022

Added an option to control processing jobs with no queue name set #205

Added an option to control processing jobs with no queue name set #205

Conversation

ahg-g commented Apr 11, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

k8s-ci-robot commented Apr 11, 2022

ahg-g commented Apr 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alculquicondor commented Apr 11, 2022

ahg-g commented Apr 11, 2022

alculquicondor left a comment

Choose a reason for hiding this comment

ahg-g commented Apr 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerthcet Apr 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerthcet Apr 12, 2022 •

edited

Loading