-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ProvisioningRequest's classname annotation #2052
Add the ProvisioningRequest's classname annotation #2052
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign @yaroslava-serdiuk |
6577426
to
1491e2e
Compare
/lgtm |
LGTM label has been added. Git tree hash: 6eac5d5dd5434eb6a551fc9c95707f73f8fe9d16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mimowo @alculquicondor Do we need to cherry pick this to release v0.6 branch?
I'm not sure if we need to do it since IIRC, the provisioning requests is not yet cutting a release (no objections).
ConsumesAnnotationKey = "cluster-autoscaler.kubernetes.io/consume-provisioning-request" | ||
ClassNameAnnotationKey = "cluster-autoscaler.kubernetes.io/provisioning-class-name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alculquicondor @mwielgus @yaroslava-serdiuk Could we move those annotations to apis
module in the autoscaler repository, and then could we import them to kueue side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will move those annotation in autoscaler repo.
/remove-kind bug No, this will only be necessary for future versions of cluster-autoscaler that will depend on this. /approve I'll leave lgtm to @yaroslava-serdiuk, as CA expert. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, PBundyra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2051
Special notes for your reviewer:
I've tested it e2e manually
Does this PR introduce a user-facing change?