Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ProvisioningRequest's classname annotation #2052

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Add the ProvisioningRequest's classname annotation #2052

merged 2 commits into from
Apr 25, 2024

Conversation

PBundyra
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2051

Special notes for your reviewer:

I've tested it e2e manually

Does this PR introduce a user-facing change?

Pods created by Kueue have now the ProvisioningRequest's classname annotation

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 87cd2d1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6628ddb658808e000846644b

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2024
@PBundyra
Copy link
Contributor Author

/assign @yaroslava-serdiuk
/assign @alculquicondor

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2024
@yaroslava-serdiuk
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6eac5d5dd5434eb6a551fc9c95707f73f8fe9d16

tenzen-y
tenzen-y reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mimowo @alculquicondor Do we need to cherry pick this to release v0.6 branch?
I'm not sure if we need to do it since IIRC, the provisioning requests is not yet cutting a release (no objections).

pkg/controller/admissionchecks/provisioning/constants.go
Comment on lines +22 to +23
ConsumesAnnotationKey = "cluster-autoscaler.kubernetes.io/consume-provisioning-request"
ClassNameAnnotationKey = "cluster-autoscaler.kubernetes.io/provisioning-class-name"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alculquicondor @mwielgus @yaroslava-serdiuk Could we move those annotations to apis module in the autoscaler repository, and then could we import them to kueue side?

https://github.com/kubernetes/autoscaler/blob/70c0ce913d8f05506992977ade9aae1c9a1dd6f0/cluster-autoscaler/provisioningrequest/pods/pods.go#L31-L34

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will move those annotation in autoscaler repo.

@alculquicondor
Copy link
Contributor

/remove-kind bug
/kind feature

No, this will only be necessary for future versions of cluster-autoscaler that will depend on this.

/approve

I'll leave lgtm to @yaroslava-serdiuk, as CA expert.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit ab2dac1 into kubernetes-sigs:main Apr 25, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Apr 25, 2024
@PBundyra PBundyra deleted the provreq-annotation branch July 31, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslava-serdiuk yaroslava-serdiuk yaroslava-serdiuk left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@alculquicondor alculquicondor

@yaroslava-serdiuk yaroslava-serdiuk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Add the ProvisioningRequest's classname annotation to pods
5 participants
@PBundyra @yaroslava-serdiuk @k8s-ci-robot @alculquicondor @tenzen-y