-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ComponentConfig API #207
Conversation
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
42f85b0
to
3b6f8db
Compare
@@ -20,9 +20,3 @@ spec: | |||
- containerPort: 8443 | |||
protocol: TCP | |||
name: https | |||
- name: manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave --zap-log-level
at least. In case someone wants to disable the componentconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squashed
@@ -20,9 +20,3 @@ spec: | |||
- containerPort: 8443 | |||
protocol: TCP | |||
name: https | |||
- name: manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Adds ComponentConfig API with a flag to tune whether or not to process jobs with queue-name not set.
Which issue(s) this PR fixes:
Fixes #172