-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using patch/apply on update pods. #2074
Using patch/apply on update pods. #2074
Conversation
Hi @mbobrovskyi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
/test all |
/cc @alculquicondor |
"sigs.k8s.io/controller-runtime/pkg/client" | ||
) | ||
|
||
func CreatePatch(before, after client.Object) (client.Patch, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the similar function in the workload
package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean this one dddbf3d? I didn't found it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry, @gabesaba just experimented with it but we didn't merge it :)
/lgtm |
LGTM label has been added. Git tree hash: dcff22d9687f8cb0ff1dd34a8f2b2aa4d8e8797f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
|
@alculquicondor Could we cherry pick this to 0.6? |
/cherry-pick release-0.6 |
@alculquicondor: #2074 failed to apply on top of branch "release-0.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mbobrovskyi Could you submit a cherry pick PR manually? This cherrypicker would be helpful: https://github.com/kubernetes-sigs/kueue/blob/main/hack/cherry_pick_pull.sh |
/release-note-edit
|
/remove-kind feature |
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
Using patch/apply on update pods.
Which issue(s) this PR fixes:
Fixes #2056
Special notes for your reviewer:
Does this PR introduce a user-facing change?