Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.6] Improve logging of workload status #2080

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[release-0.6] Improve logging of workload status #2080

merged 1 commit into from
Apr 26, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2062

/assign mimowo

Correctly log workload status for workloads with quota reserved, but awaiting for admission checks.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 26, 2024
Merged
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Apr 26, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2024
@mimowo
Copy link
Contributor

mimowo commented Apr 26, 2024

/assign @tenzen-y @alculquicondor

@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 353486b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/662bd5da2bdcf1000886fefd
😎 Deploy Preview https://deploy-preview-2080--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tenzen-y
tenzen-y reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d44a149fb0a47d3c6092ceab3c6dec4d4334086

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit cee71b0 into kubernetes-sigs:release-0.6 Apr 26, 2024
13 checks passed
@alculquicondor
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@alculquicondor alculquicondor

@mimowo mimowo

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @mimowo @k8s-ci-robot @alculquicondor @tenzen-y