-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidecar containers to resource requests computation #2099
Add sidecar containers to resource requests computation #2099
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Please add a release note. |
How urgent is this? Is it acceptable to wait until kubernetes/kubernetes#124537 is fixed, and use that library? @alculquicondor |
No, we cannot wait. That change will only be available in a released module when all of v1.31 is released, which will be ~3 months from now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, just a few nits. thanks for addressing the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit tests look solid :)
/test pull-kueue-test-integration-main |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: df9454efb9a3ffa1eafdb3d2d48d9edc8dc9219d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, IrvingMg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.6 |
@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@alculquicondor: #2099 failed to apply on top of branch "release-0.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@IrvingMg Could you open a PR manually? |
…quests computation (#2159) * Add sidecar containers to resource requests computation * Refactor init containers resource computation * Refactor tests cases using Container wrapper * Update test cases * Refactor sidecar condition * Update tests * Update formula to compute resource requests * Make init containers resource computation linear * Update init containers resource computation
What type of PR is this?
/kind bug
What this PR does / why we need it:
Includes
SidecarContainers
in the computation of total resource requests of a pod.Which issue(s) this PR fixes:
Fixes #2068
Special notes for your reviewer:
The new formula to calculate the total was extracted from KEP-753.
Does this PR introduce a user-facing change?