ConfigAPI: Implement the MultiKueue validations #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
release-note
4 tasks
|
/remove-kind bug |
k8s-ci-robot
added
kind/feature
mimowo
reviewed
May 6, 2024
| return allErrs | ||
| } | ||
|
|
||
| func validateMultiKueue(c *configapi.Configuration) field.ErrorList { |
There was a problem hiding this comment.
I think we should also add validation for the origin label, using IsValidLabelValue.
tenzen-y
force-pushed
the
implement-multikueue-config-validations
branch
2 times, most recently
from
ab93755
to
d3ef458
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
implement-multikueue-config-validations
branch
from
d3ef458
to
668f440
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c98deedb200371ac7b11ab7ac07fdb520e0650b7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
We could not generate CRD validations in the ConfigAPI since the ConfigAPI is not CRD.
So, we need to validate the Configurations when the manager boosts up.
Which issue(s) this PR fixes:
Part-of #2084
Special notes for your reviewer:
Does this PR introduce a user-facing change?