[kueuectl] Add stop/resume workload commands #2134
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XL
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/cc @alculquicondor |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-kueue-test-integration-main |
|
/assign @mwielgus |
mbobrovskyi
force-pushed
the
feature/kueuectl-stop-resume-workload
branch
2 times, most recently
from
c95ab1e
to
9cfe622
Compare
|
/assign @trasc |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ccdfda80562a74d75effec764cefe76ba53dcb20
|
mbobrovskyi
force-pushed
the
feature/kueuectl-stop-resume-workload
branch
from
eb7e263
to
454841c
Compare
k8s-ci-robot
removed
the
lgtm
|
Anything to add @mwielgus ? |
|
|
||
| const ( | ||
| resumeExample = ` # Resume the workload | ||
| kueuectl resume workload my-workload` |
There was a problem hiding this comment.
For a follow up, but it would be awesome to support any job object, and kueuectl automatically finds the workload for it.
| | workload | wl | kueue.x-k8s.io/v1beta1 | true | Workload | | ||
|
|
||
|
|
||
| ## Create |
There was a problem hiding this comment.
I don't necessarily oppose all these details, but I think we can get away without them.
Using help in the CLI should be more than enough.
There was a problem hiding this comment.
@mwielgus, wdyt?
There was a problem hiding this comment.
I think this will be hard to maintain. I prefer we don't add all this detail.
@mwielgus, wdyt?
There was a problem hiding this comment.
Let's not add everything for now.
let's maybe stop at a 2 level hierarchy:
kubectl-kueue
index
installation
commands
create
resume
stop
There was a problem hiding this comment.
+1 on splitting this
| weight: 10 | ||
| description: > | ||
| The kubectl-kueue plugin, kueuectl, allows you to manage Kueue resources. | ||
| --- |
There was a problem hiding this comment.
shouldn't this have the contents that are currently on kubectl-kueue.md?
|
/test pull-kueue-test-integration-main |
mbobrovskyi
force-pushed
the
feature/kueuectl-stop-resume-workload
branch
from
bba0c3e
to
b88c020
Compare
mbobrovskyi
force-pushed
the
feature/kueuectl-stop-resume-workload
branch
from
294ac31
to
d76614d
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f4978c87454e8c703646e771ad0ea525bae9dbe2
|
|
/assign @alculquicondor |
There was a problem hiding this comment.
site/content/en/docs/reference/kubectl-kueue/commands/create/_index.md
to avoid stutter
mbobrovskyi
force-pushed
the
feature/kueuectl-stop-resume-workload
branch
from
d76614d
to
e946f9a
Compare
k8s-ci-robot
removed
the
lgtm
There was a problem hiding this comment.
It looks like you forgot to change the folder name
mbobrovskyi
force-pushed
the
feature/kueuectl-stop-resume-workload
branch
from
e946f9a
to
3b17bc4
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 820076759cdc9efdf7fab22de51cfb06ff25238b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/release-note-edit |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2132 and #2133
Special notes for your reviewer:
Does this PR introduce a user-facing change?