-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Provisioning Request status as events for Pods/Jobs #2147
Conversation
Hi @pajakd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/ok-to-test |
/cc |
/assign @yaroslava-serdiuk |
if message != "" { | ||
if cJob, isComposable := job.(ComposableJob); isComposable { | ||
cJob.ForEach(func(obj runtime.Object) { | ||
r.record.Eventf(obj, corev1.EventTypeNormal, ReasonUpdatedWorkload, message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a dedicated reason for this, like AdmissionCheckUpdates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
if message != "" { | ||
message += "; " | ||
} | ||
message += "Admission check: \"" + check.Name + "\", Message: \"" + check.Message + "\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of extra characters.
Maybe just check.Name + ": " + chek.Message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Leaving LGTM to @yaroslava-serdiuk
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, pajakd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 823a866fa70bb72aad077d04f186880956532bd2
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
In #2007 the ETA messages from the Provisioning Request are propagated to Workload status. In this PR the objective is to expose these messages as events for job/pod objects. In case of multiple admission checks at some object, the messages are aggregated into a single event. For pod groups, a separate event is recorded for each member of the group.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?