Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Provisioning Request status as events for Pods/Jobs #2147

Merged
merged 13 commits into from
May 10, 2024
Merged

Expose Provisioning Request status as events for Pods/Jobs #2147

merged 13 commits into from
May 10, 2024

Conversation

pajakd
Copy link
Contributor

@pajakd pajakd commented May 7, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

In #2007 the ETA messages from the Provisioning Request are propagated to Workload status. In this PR the objective is to expose these messages as events for job/pod objects. In case of multiple admission checks at some object, the messages are aggregated into a single event. For pod groups, a separate event is recorded for each member of the group.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updates in admission check messages are recorded as events for jobs/pods.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 7, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @pajakd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2024
@netlify Netlify
Copy link

netlify bot commented May 7, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 5dfa93e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/663cd38b5fb4ed0008bd8063

@trasc
Copy link
Contributor

trasc commented May 7, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2024
@alculquicondor
Copy link
Contributor

/cc

@alculquicondor
Copy link
Contributor

/assign @yaroslava-serdiuk

alculquicondor
alculquicondor reviewed May 7, 2024
View reviewed changes
pkg/controller/jobframework/reconciler.go Outdated
if message != "" {
if cJob, isComposable := job.(ComposableJob); isComposable {
cJob.ForEach(func(obj runtime.Object) {
r.record.Eventf(obj, corev1.EventTypeNormal, ReasonUpdatedWorkload, message)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a dedicated reason for this, like AdmissionCheckUpdates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

alculquicondor
alculquicondor reviewed May 8, 2024
View reviewed changes
pkg/controller/jobframework/reconciler.go Outdated
if message != "" {
message += "; "
}
message += "Admission check: \"" + check.Name + "\", Message: \"" + check.Message + "\""
Copy link
Contributor

@alculquicondor alculquicondor May 8, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of extra characters.
Maybe just check.Name + ": " + chek.Message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

alculquicondor
alculquicondor reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Leaving LGTM to @yaroslava-serdiuk

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, pajakd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@tenzen-y tenzen-y mentioned this pull request May 9, 2024
Open
3 tasks
@yaroslava-serdiuk
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 823a866fa70bb72aad077d04f186880956532bd2

@k8s-ci-robot k8s-ci-robot merged commit b870144 into kubernetes-sigs:main May 10, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 10, 2024
@pajakd pajakd deleted the events branch May 10, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@yaroslava-serdiuk yaroslava-serdiuk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pajakd @k8s-ci-robot @trasc @alculquicondor @yaroslava-serdiuk