Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Admitted condition reason while using admission checks. #2150

Merged
merged 1 commit into from
May 8, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented May 7, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Use UnsatisfiedChecks instead of NoChecks in the Admitted condition Reason.

Which issue(s) this PR fixes:

Fixes #2121

Special notes for your reviewer:

Does this PR introduce a user-facing change?

When using admission checks, and they are not satisfied yet, the reason for the Admission condition with status=False is now
`UnsatisfiedChecks`

ACTION REQUIRED: If you were watching for the reason `NoChecks` in the Admitted condition, use `UnsatisfiedChecks` instead.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 7, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 07ab095
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/663a20f419a49800080c7fab

@trasc
Copy link
Contributor Author

trasc commented May 8, 2024

/cc @alculquicondor

@alculquicondor
Copy link
Contributor

/release-note-edit

When using admission checks, and they are not satisfied yet, the reason for the Admission condition with status=False is now
`UnsatisfiedChecks`

ACTION REQUIRED: If you were watching for the reason `NoChecks` in the Admitted condition, use `UnsatisfiedChecks` instead.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 8, 2024
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a08a8f07b6c1b781d6405816b64fa32e36120438

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit db28cd0 into kubernetes-sigs:main May 8, 2024
12 of 15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 8, 2024
@trasc trasc deleted the ac-reason branch May 9, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear reason in Admitted condition when using admission checks
3 participants