-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kueuectl] Add list LocalQueue command. #2157
[kueuectl] Add list LocalQueue command. #2157
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/ok-to-test |
/test pull-kueue-test-integration-main |
/assign @trasc |
Created another PR #2157 to fix integration tests. |
Also about active/inactive filter, we will add it on the next follow up after finished #2109. |
fe72677
to
36b2203
Compare
d560580
to
9e40be7
Compare
@mwielgus I wonder why is it named For me right now it looks like it's totally the same as p.s. We can create a suggestions for |
25c7661
to
b96015a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 00ce31ac029253cae98255e138591983e6fa2b34
|
/assign @alculquicondor |
b96015a
to
0d1bf9b
Compare
0d1bf9b
to
a701a35
Compare
cmd/kueuectl/app/util/factory.go
Outdated
return nil, err | ||
} | ||
|
||
clientset, err := versioned.NewForConfig(config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not store the clientset?
a701a35
to
9643157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 3c3da0f3f0fa30556da96de76d74a0a5e52acee4
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
|
@alculquicondor: /release-note-edit must be used with a release note block. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/release-note-edit
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
To get list LocalQueues that match the given criteria: point to a specific CQ, being active/inactive, belonging to the specified namespace or matching the label selector.
Which issue(s) this PR fixes:
Fixes #2115
Special notes for your reviewer:
Does this PR introduce a user-facing change?