[multikueue] Reconcile the relevant ACs on cluster create. #2165
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -267,7 +267,7 @@ func (m *mkClusterHandler) Create(ctx context.Context, event event.CreateEvent, | |||
| return | |||
| } | |||
|
|
|||
| if err := queueReconcileForConfigUsers(ctx, mkc.Name, m.client, q); err != nil { | |||
| if err := m.queue(ctx, mkc, q); err != nil { | |||
There was a problem hiding this comment.
Doesn't the fact that we could not detect this bug in the test indicate that we don't have any cases to verify here?
There was a problem hiding this comment.
The problem is that we don't test (and I don't think it's easy to do) the create only scenario, after the cluster is created one of the first things happening is for it's active condition to be set, triggering an Update which worked well.
There was a problem hiding this comment.
Uhm, couldn't add a unit test for creation?
There was a problem hiding this comment.
That will be the first if it's king in the entire project.
There was a problem hiding this comment.
That will be the first if it's king in the entire project.
@trasc Alright. Could you create tracking issue?
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ccc0e7b426b56ee0ec334ebf0fb1f1eef03a0c0d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
|
/release-note-edit |
k8s-ci-robot
added
release-note
|
/cherry-pick release-0.6 |
|
@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tenzen-y: new pull request created: #2167 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
[multikueue] Reconcile the relevant ACs on cluster create.
Which issue(s) this PR fixes:
Fixes #2117
Special notes for your reviewer:
Does this PR introduce a user-facing change?