Provide support for ProvisioningRequest's CapacityRevoked condition #2196

PBundyra · 2024-05-14T08:28:02Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Provide support for the new ProvisioningRequest's condition CapacityRevoked. When user uses a job that allows retries and sets .spec.backOffLimit > 0 and the job gets evicted because of MaxRunDuration an according AdmissionCheck gets rejected.

After a Workload is finished we no longer delete corresponding ProvisioningRequest. This is because Workload might be finished due to MaxRunDuration timeout, before ClusterAutoscaler updates ProvisioningRequest's status to CapacityRevoked and the Kueue's controller has no opportunity to react to that.

Additionally I did a small cleanup.

Which issue(s) this PR fixes:

Part of #2041

Special notes for your reviewer:

I've tested it e2e manually

Does this PR introduce a user-facing change?

ProvisioningRequets: Support for ProvisioningRequest's condition `CapacityRevoked`. ProvisioningRequests objects persist until the corresponding Job or the Workload is deleted

netlify · 2024-05-14T08:28:18Z

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	`bbcf7c5`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6662c8dfedea9f0008ea2d70

PBundyra · 2024-05-14T08:28:45Z

/assign @yaroslava-serdiuk
/assign @alculquicondor

yaroslava-serdiuk · 2024-05-14T10:20:18Z

please, fix the tests

yaroslava-serdiuk

Minor comment

pkg/controller/admissionchecks/provisioning/provisioning.go

yaroslava-serdiuk · 2024-05-15T09:23:00Z

Please, rebase the PR to resolve merge conflict

yaroslava-serdiuk · 2024-05-15T14:06:05Z

/lgtm

k8s-ci-robot · 2024-05-15T14:06:11Z

LGTM label has been added.

Git tree hash: 22bd86626a7137e9e4aebc737e06cc5dcebd29d5

PBundyra · 2024-05-16T11:03:34Z

/assign @tenzen-y

alculquicondor · 2024-05-16T19:05:40Z

Please also add to the release note that ProvisioningRequests objects persist until the Job or the Workload is deleted, IIUC.

pkg/controller/admissionchecks/provisioning/controller.go

pkg/controller/admissionchecks/provisioning/controller_test.go

pkg/controller/admissionchecks/provisioning/controller.go

pkg/controller/admissionchecks/provisioning/provisioning.go

pkg/workload/workload.go

mimowo

One more comment / question regarding sending workload updates per AC

pkg/controller/admissionchecks/provisioning/controller.go

mimowo · 2024-06-06T11:27:46Z

/lgtm
@tenzen-y anything to add? The deactivation will happen in the follow up PR.

k8s-ci-robot · 2024-06-06T11:27:51Z

LGTM label has been added.

Git tree hash: 4d47a984051746c6a582c663b021d272b2b094fc

tenzen-y · 2024-06-06T11:34:59Z

/lgtm @tenzen-y anything to add? The deactivation will happen in the follow up PR.

Let me see this.

alculquicondor · 2024-06-06T19:43:45Z

Please update description and release note.

alculquicondor

/approve
/hold
for nit and description updates.

pkg/controller/admissionchecks/provisioning/controller.go

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>

tenzen-y

Basically, lgtm

test/integration/controller/admissionchecks/provisioning/provisioning_test.go

pkg/workload/workload.go

tenzen-y

Thank you!
/lgtm
/approve

k8s-ci-robot · 2024-06-07T08:48:24Z

LGTM label has been added.

Git tree hash: 8c067e1612f2fd8f0620a2824677ee2fa7bf2e0f

k8s-ci-robot · 2024-06-07T08:48:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, PBundyra, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alculquicondor,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tenzen-y · 2024-06-07T09:09:25Z

/hold

tenzen-y · 2024-06-07T09:09:31Z

/hold cancel

…ubernetes-sigs#2196) * Provide support for ProvisioningRequest's CapacityRevoked condition * Clean-up * Improve naming * Add an unit test case, cleanup logs, slight logic changes to provisioning controller * Clean up, improve integration tests for provisioning request, set Evicted condition for Workload if the capacity for a ProvisioningRequest has been revoked * Add controllers to ProvisioningRequest integration tests, check evicted metric in integration tests, do not set evicted condition in the provisioning controller * Fix integration tests * Delete unit test that checks if that Evicted conditions stays the same * Discard deactivating workload in the provisioning controller * Batch workload status updates * Update pkg/controller/admissionchecks/provisioning/controller.go Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com> * Use IsActive function, clean up provisioning integration tests ---------

…ubernetes-sigs#2196) * Provide support for ProvisioningRequest's CapacityRevoked condition * Clean-up * Improve naming * Add an unit test case, cleanup logs, slight logic changes to provisioning controller * Clean up, improve integration tests for provisioning request, set Evicted condition for Workload if the capacity for a ProvisioningRequest has been revoked * Add controllers to ProvisioningRequest integration tests, check evicted metric in integration tests, do not set evicted condition in the provisioning controller * Fix integration tests * Delete unit test that checks if that Evicted conditions stays the same * Discard deactivating workload in the provisioning controller * Batch workload status updates * Update pkg/controller/admissionchecks/provisioning/controller.go Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com> * Use IsActive function, clean up provisioning integration tests --------- Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>

alculquicondor · 2024-07-18T20:43:27Z

/release-note-edit

ProvisioningRequets: Support for ProvisioningRequest's condition `CapacityRevoked`. ProvisioningRequests objects persist until the corresponding Job or the Workload is deleted

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 14, 2024

k8s-ci-robot requested review from kerthcet and trasc May 14, 2024 08:28

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2024

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 14, 2024

k8s-ci-robot assigned alculquicondor and yaroslava-serdiuk May 14, 2024

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2024

PBundyra force-pushed the support-provreq branch 4 times, most recently from 5726dba to 8fe6b4f Compare May 14, 2024 10:50

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2024

yaroslava-serdiuk reviewed May 14, 2024

View reviewed changes

pkg/controller/admissionchecks/provisioning/provisioning.go Outdated Show resolved Hide resolved

PBundyra force-pushed the support-provreq branch 2 times, most recently from cff252f to cf6330a Compare May 15, 2024 11:26

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024

k8s-ci-robot assigned tenzen-y May 16, 2024

alculquicondor reviewed May 16, 2024

View reviewed changes

PBundyra mentioned this pull request Jun 5, 2024

Deactivate Workload if any of its AdmissionCheck get Rejected #2363

Merged

mimowo reviewed Jun 6, 2024

View reviewed changes

pkg/controller/admissionchecks/provisioning/controller.go Outdated Show resolved Hide resolved

Batch workload status updates

9fdb6e5

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2024

alculquicondor reviewed Jun 6, 2024

View reviewed changes

pkg/controller/admissionchecks/provisioning/controller.go Outdated Show resolved Hide resolved

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2024

Update pkg/controller/admissionchecks/provisioning/controller.go

01d788d

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024

k8s-ci-robot requested review from alculquicondor and mimowo June 7, 2024 07:22

tenzen-y reviewed Jun 7, 2024

View reviewed changes

test/integration/controller/admissionchecks/provisioning/provisioning_test.go Outdated Show resolved Hide resolved

pkg/workload/workload.go Show resolved Hide resolved

Use IsActive function, clean up provisioning integration tests

bbcf7c5

tenzen-y reviewed Jun 7, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024

k8s-ci-robot merged commit d728cb8 into kubernetes-sigs:main Jun 7, 2024
16 checks passed

k8s-ci-robot added this to the v0.8 milestone Jun 7, 2024

PBundyra deleted the support-provreq branch July 31, 2024 11:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide support for ProvisioningRequest's CapacityRevoked condition #2196

Provide support for ProvisioningRequest's CapacityRevoked condition #2196

PBundyra commented May 14, 2024 •

edited by k8s-ci-robot

Loading

netlify bot commented May 14, 2024 •

edited

Loading

PBundyra commented May 14, 2024

yaroslava-serdiuk commented May 14, 2024

yaroslava-serdiuk left a comment

yaroslava-serdiuk commented May 15, 2024

yaroslava-serdiuk commented May 15, 2024

k8s-ci-robot commented May 15, 2024

PBundyra commented May 16, 2024

alculquicondor commented May 16, 2024

mimowo left a comment

mimowo commented Jun 6, 2024

k8s-ci-robot commented Jun 6, 2024

tenzen-y commented Jun 6, 2024

alculquicondor commented Jun 6, 2024

alculquicondor left a comment •

edited

Loading

tenzen-y left a comment

tenzen-y left a comment

k8s-ci-robot commented Jun 7, 2024

k8s-ci-robot commented Jun 7, 2024

tenzen-y commented Jun 7, 2024

tenzen-y commented Jun 7, 2024

alculquicondor commented Jul 18, 2024

Provide support for ProvisioningRequest's CapacityRevoked condition #2196

Provide support for ProvisioningRequest's CapacityRevoked condition #2196

Conversation

PBundyra commented May 14, 2024 • edited by k8s-ci-robot Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

netlify bot commented May 14, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

PBundyra commented May 14, 2024

yaroslava-serdiuk commented May 14, 2024

yaroslava-serdiuk left a comment

Choose a reason for hiding this comment

yaroslava-serdiuk commented May 15, 2024

yaroslava-serdiuk commented May 15, 2024

k8s-ci-robot commented May 15, 2024

PBundyra commented May 16, 2024

alculquicondor commented May 16, 2024

mimowo left a comment

Choose a reason for hiding this comment

mimowo commented Jun 6, 2024

k8s-ci-robot commented Jun 6, 2024

tenzen-y commented Jun 6, 2024

alculquicondor commented Jun 6, 2024

alculquicondor left a comment • edited Loading

Choose a reason for hiding this comment

tenzen-y left a comment

Choose a reason for hiding this comment

tenzen-y left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 7, 2024

k8s-ci-robot commented Jun 7, 2024

tenzen-y commented Jun 7, 2024

tenzen-y commented Jun 7, 2024

alculquicondor commented Jul 18, 2024

PBundyra commented May 14, 2024 •

edited by k8s-ci-robot

Loading

netlify bot commented May 14, 2024 •

edited

Loading

alculquicondor left a comment •

edited

Loading