Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kueuectl] Stop/resume cluster queue #2200

Merged
merged 3 commits into from
May 21, 2024
Merged

[kueuectl] Stop/resume cluster queue #2200

merged 3 commits into from
May 21, 2024

Conversation

vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented May 14, 2024 •
edited by k8s-ci-robot

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds kueuectl stop clusterqueue, kueuectl resume clusterqueue commands

Which issue(s) this PR fixes:

Fixes #2136 and #2137

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CLI: Add commands to stop and Resume a ClusterQueue

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2024
@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit d3a9b71
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/664a655dfb33b0000897bdd3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 16, 2024
@vladikkuzn
Copy link
Contributor Author

/assign

@vladikkuzn
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 16, 2024
@vladikkuzn vladikkuzn changed the title [kueuectl] Stop cluster queue [kueuectl] Stop/resume cluster queue May 16, 2024
@vladikkuzn
Copy link
Contributor Author

/cc @trasc

@vladikkuzn
Copy link
Contributor Author

/cc @IrvingMg @mwielgus @mbobrovskyi

@vladikkuzn vladikkuzn marked this pull request as ready for review May 16, 2024 16:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mimowo May 16, 2024 16:07
trasc
trasc reviewed May 16, 2024
View reviewed changes
cmd/kueuectl/app/resume/resume_clusterqueue.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/resume/resume_clusterqueue.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/resume/resume_clusterqueue.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/stop/helpers.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/stop/stop_clusterqueue.go Outdated Show resolved Hide resolved
test/integration/kueuectl/resume_test.go Outdated Show resolved Hide resolved
test/integration/kueuectl/resume_test.go Outdated Show resolved Hide resolved
test/integration/kueuectl/stop_test.go Outdated Show resolved Hide resolved
test/integration/kueuectl/stop_test.go Outdated Show resolved Hide resolved
test/integration/kueuectl/stop_test.go Outdated Show resolved Hide resolved
@vladikkuzn vladikkuzn marked this pull request as draft May 17, 2024 12:53
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024
@vladikkuzn vladikkuzn force-pushed the kueuectl-stop-cq branch 2 times, most recently from 8d00692 to 8a6ec91 Compare May 19, 2024 20:21
@vladikkuzn
[kueuectl] Stop/resume cluster queue
d3a9b71 
* Use deref in tests
* NITs
* Table tests
@vladikkuzn
Copy link
Contributor Author

/retest

@vladikkuzn vladikkuzn marked this pull request as ready for review May 19, 2024 21:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from trasc May 19, 2024 21:18
@vladikkuzn
Copy link
Contributor Author

/cc @mwielgus @alculquicondor

tenzen-y
tenzen-y reviewed May 20, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@tenzen-y
Copy link
Member

leaving lgtm on @trasc

trasc
trasc reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0001a18d0e80dfabd8c5dd316d0977f6c20f22bf

@k8s-ci-robot k8s-ci-robot merged commit 05ad41d into kubernetes-sigs:main May 21, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 21, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

CLI: Add commands to stop and Resume a ClusterQueue

@vladikkuzn vladikkuzn deleted the kueuectl-stop-cq branch June 19, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@IrvingMg IrvingMg IrvingMg left review comments

@trasc trasc trasc left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@mwielgus mwielgus Awaiting requested review from mwielgus

@mimowo mimowo Awaiting requested review from mimowo

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@vladikkuzn vladikkuzn

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

[kueuectl] Add stop ClusterQueue command
8 participants
@vladikkuzn @k8s-ci-robot @tenzen-y @alculquicondor @mwielgus @mbobrovskyi @IrvingMg @trasc