-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.6] WaitForPodsReady: Load the backoffLimitCount regardless of the requeueingStrategy.timestamp #2224
[release-0.6] WaitForPodsReady: Load the backoffLimitCount regardless of the requeueingStrategy.timestamp #2224
Conversation
|
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
a54caa5
to
f790c70
Compare
Why Aldo is not recognized 🧐 |
/easycla |
I was informed that there was an issue in the CLA check system. I'm asking around if there are other workarounds. |
Can you try removing me from co-author? Maybe it's messing something up? |
Oh, I see. Thank you! |
co-author should work, it's not registering someone as having signed |
Let me try it |
…eingStrategy.timestamp Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
f790c70
to
fc02f3e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: bdec16aa783b85c94089398f0f1cfbd8d1e7a241
|
Once I remove the co-authored, that should work well, although I really don't prefer to remove co-authored... |
I think there's a temporary issue with this and/or Aldo's account, I use co-authored pretty regularly in the org FWIW. Hopefully we can sort that out with the CNCF soon. |
Thanks! |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If we don't set the
requeuingStrategy.timestamp
, thebackoffLimitCount
is ignored.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This has already been fixed in #2040 as a feature enhancement.
Does this PR introduce a user-facing change?