Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.6] WaitForPodsReady: Load the backoffLimitCount regardless of the requeueingStrategy.timestamp #2224

Conversation

tenzen-y
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

If we don't set the requeuingStrategy.timestamp , the backoffLimitCount is ignored.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This has already been fixed in #2040 as a feature enhancement.

Does this PR introduce a user-facing change?

Fix a bug that the ".waitForPodsReady.requeuingStrategy.backoffLimitCount" is ignored when the ".waitForPodsReady.requeuingStrategy.timestamp" is not set.

@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone May 17, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels May 17, 2024
Copy link

linux-foundation-easycla bot commented May 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tenzen-y / name: Yuki Iwai (fc02f3e)

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2024
Copy link

netlify bot commented May 17, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit fc02f3e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6647a7639673660008934b4b

@tenzen-y tenzen-y force-pushed the fix-waitforpodsready-defaulting branch from a54caa5 to f790c70 Compare May 17, 2024 18:46
@tenzen-y
Copy link
Member Author

Why Aldo is not recognized 🧐

@alculquicondor
Copy link
Contributor

/easycla

@alculquicondor
Copy link
Contributor

I was informed that there was an issue in the CLA check system. I'm asking around if there are other workarounds.

@alculquicondor
Copy link
Contributor

Can you try removing me from co-author? Maybe it's messing something up?

@tenzen-y
Copy link
Member Author

I was informed that there was an issue in the CLA check system. I'm asking around if there are other workarounds.

Oh, I see. Thank you!

@BenTheElder
Copy link
Member

co-author should work, it's not registering someone as having signed

@tenzen-y
Copy link
Member Author

Can you try removing me from co-author? Maybe it's messing something up?

Let me try it

…eingStrategy.timestamp

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the fix-waitforpodsready-defaulting branch from f790c70 to fc02f3e Compare May 17, 2024 18:52
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 17, 2024
@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alculquicondor,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bdec16aa783b85c94089398f0f1cfbd8d1e7a241

@tenzen-y
Copy link
Member Author

Once I remove the co-authored, that should work well, although I really don't prefer to remove co-authored...

@k8s-ci-robot k8s-ci-robot merged commit f79882a into kubernetes-sigs:release-0.6 May 17, 2024
13 checks passed
@BenTheElder
Copy link
Member

I think there's a temporary issue with this and/or Aldo's account, I use co-authored pretty regularly in the org FWIW.

Hopefully we can sort that out with the CNCF soon.

@tenzen-y tenzen-y deleted the fix-waitforpodsready-defaulting branch May 17, 2024 19:39
@tenzen-y
Copy link
Member Author

FWIW

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants