Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2131: Move the eviction by inactivation mechanism from the #2229

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented May 20, 2024

Cherry pick of #2131 on release-0.6.
#2131: Move the eviction by inactivation mechanism from the
For details on the cherry pick process, see the cherry pick requests page.

JobFramework: The eviction by inactivation mechanism was moved to the workload controller.

This fixes a problem where pod groups would remain with condition QuotaReserved set to True when replacement pods are missing.

…onciler to the workload controller

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone May 20, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2024
Copy link

netlify bot commented May 20, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 3713dfc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/664b8d050da9670008f232ac

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 20, 2024
@mbobrovskyi
Copy link
Contributor Author

Fixes #2222

@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented May 20, 2024

/cc @alculquicondor

@mbobrovskyi
Copy link
Contributor Author

/assign @alculquicondor @tenzen-y

…dy got Eviction (kubernetes-sigs#2172)

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
(cherry picked from commit 2b90363)
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2024
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 34e76f942b0ca998755b411b2580c24e52963991

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3d4b2fd into kubernetes-sigs:release-0.6 May 20, 2024
13 checks passed
@mbobrovskyi mbobrovskyi deleted the automated-cherry-pick-of-#2131-upstream-release-0.6 branch May 20, 2024 18:32
@alculquicondor
Copy link
Contributor

/kind bug

/release-note-edit

JobFramework: The eviction by inactivation mechanism was moved to the workload controller.

This fixes a problem where pod groups would remain with condition QuotaReserved set to True when replacement pods are missing.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants