Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show fair share of a CQ in status and a metric #2276

Merged
merged 1 commit into from
May 27, 2024
Merged

Show fair share of a CQ in status and a metric #2276

merged 1 commit into from
May 27, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented May 24, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Show fair share of a CQ in status and a metric.

Which issue(s) this PR fixes:

Fixes #2258

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Show fair share of a CQ in status and a metric

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels May 24, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2024
@netlify Netlify
Copy link

netlify bot commented May 24, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 1ac6a70
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6654b8e2c7dbfb0008ad4967

@mbobrovskyi mbobrovskyi changed the title Show fair share of a CQ in status and a metric. Show fair share of a CQ in status and a metric May 24, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/show-fair-share-of-a-cq-in-status-and-a-metric branch from 6494688 to 4f80d0c Compare May 24, 2024 15:39
@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 24, 2024
@mbobrovskyi
Copy link
Contributor Author

/assign @trasc

alculquicondor
alculquicondor reviewed May 24, 2024
View reviewed changes
apis/kueue/v1beta1/clusterqueue_types.go Outdated Show resolved Hide resolved
apis/kueue/v1beta1/clusterqueue_types.go Outdated Show resolved Hide resolved
apis/kueue/v1beta1/clusterqueue_types.go Outdated Show resolved Hide resolved
pkg/cache/cache.go Outdated Show resolved Hide resolved
pkg/cache/clusterqueue.go Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the feature/show-fair-share-of-a-cq-in-status-and-a-metric branch from 4f80d0c to 1d5ebd3 Compare May 24, 2024 21:31
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/show-fair-share-of-a-cq-in-status-and-a-metric branch from 1d5ebd3 to 6c74e5b Compare May 24, 2024 21:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/show-fair-share-of-a-cq-in-status-and-a-metric branch from 6c74e5b to de013c8 Compare May 24, 2024 21:48
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi mbobrovskyi marked this pull request as ready for review May 27, 2024 10:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
trasc
trasc reviewed May 27, 2024
View reviewed changes
pkg/cache/cache.go Outdated Show resolved Hide resolved
pkg/cache/clusterqueue.go Outdated Show resolved Hide resolved
pkg/cache/clusterqueue.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the feature/show-fair-share-of-a-cq-in-status-and-a-metric branch from de013c8 to a5ebbc2 Compare May 27, 2024 12:25
@mbobrovskyi mbobrovskyi force-pushed the feature/show-fair-share-of-a-cq-in-status-and-a-metric branch from a5ebbc2 to cb6416b Compare May 27, 2024 14:30
alculquicondor
alculquicondor reviewed May 27, 2024
View reviewed changes
pkg/cache/clusterqueue_test.go Outdated Show resolved Hide resolved
test/integration/scheduler/fairsharing/fair_sharing_test.go Outdated Show resolved Hide resolved
test/integration/scheduler/fairsharing/fair_sharing_test.go Show resolved Hide resolved
apis/kueue/v1beta1/clusterqueue_types.go Outdated Show resolved Hide resolved
apis/kueue/v1beta1/clusterqueue_types.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the feature/show-fair-share-of-a-cq-in-status-and-a-metric branch from cb6416b to 9a700f9 Compare May 27, 2024 16:03
@mbobrovskyi
Copy link
Contributor Author

/retest

@mbobrovskyi mbobrovskyi force-pushed the feature/show-fair-share-of-a-cq-in-status-and-a-metric branch from 9a700f9 to 1ac6a70 Compare May 27, 2024 16:46
alculquicondor
alculquicondor reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d7a867953eaa5bc42527c7f147c1f542c0047ec

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2c5d9f2 into kubernetes-sigs:main May 27, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 27, 2024
@mbobrovskyi mbobrovskyi deleted the feature/show-fair-share-of-a-cq-in-status-and-a-metric branch May 27, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@trasc trasc trasc left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@alculquicondor alculquicondor

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Show fair share of a CQ in status and a metric
4 participants
@mbobrovskyi @k8s-ci-robot @alculquicondor @trasc