-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kjobctl bootstrap #2307
Kjobctl bootstrap #2307
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign @vladikkuzn @trasc |
7c0728a
to
678a8d2
Compare
acd4252
to
54fe352
Compare
cmd/experimental/kjobctl/client-go/clientset/versioned/clientset.go
Outdated
Show resolved
Hide resolved
# Generating conversion and defaults functions | ||
kube::codegen::gen_helpers \ | ||
--boilerplate ${KJOBCTL_ROOT}/hack/boilerplate.go.txt \ | ||
"${KJOBCTL_ROOT}/apis/v1alpha1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"${KJOBCTL_ROOT}/apis/v1alpha1" | |
"${KJOBCTL_ROOT}" |
I'm wondering, is it possible to set like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely it will result just in parsing extra files that are not relevant for the generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the same situation with kube::codegen::gen_client
cmd/experimental/kjobctl/README.md
Outdated
- kubectl version v1.11.3+. | ||
- Access to a Kubernetes v1.11.3+ cluster. | ||
|
||
### To Deploy on the cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### To Deploy on the cluster | |
### To prepare the cluster |
Maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not need in our case
cmd/experimental/kjobctl/config/samples/kueue.experimental_v1alpha1_volumebundle.yaml
Outdated
Show resolved
Hide resolved
# Generating conversion and defaults functions | ||
kube::codegen::gen_helpers \ | ||
--boilerplate ${KJOBCTL_ROOT}/hack/boilerplate.go.txt \ | ||
"${KJOBCTL_ROOT}/apis/v1alpha1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely it will result just in parsing extra files that are not relevant for the generator.
381bf96
to
ba804f3
Compare
/test all |
Overall LGTM |
/assign @alculquicondor |
368f618
to
2375ac6
Compare
/test all |
2375ac6
to
f323f5a
Compare
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 2b73332c73db9d3c1db8f0a188e292e17fda32d2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, vladikkuzn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Kjonctl bootstrap * [Kjobctl] Bootstrap application. --------- Co-authored-by: Mykhailo Bobrovskyi <mikhail.bobrovsky@gmail.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Introduces initial structure for kjobctl crds and cli
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?