-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigAPI: Implement the non negative validation for the queueVisibility.clusterQueues.maxCount #2309
ConfigAPI: Implement the non negative validation for the queueVisibility.clusterQueues.maxCount #2309
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
…Queues.maxCount Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
d3732a8
to
90d836d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d2e4f6a8a028cf8b3229efef4116301e88d9120b
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, the configAPI validation doesn't have non negative check for the
queueVisibility.clusterQueues.maxCount
.Which issue(s) this PR fixes:
Fixes: #2084
Special notes for your reviewer:
Does this PR introduce a user-facing change?