-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multikueue] Use batch/Job spec.managedBy
field.
#2331
[multikueue] Use batch/Job spec.managedBy
field.
#2331
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign @mimowo |
@alculquicondor @mimowo @mwielgus We could also keep the old integration approach and put the |
+1 sounds like a good idea. It will let users configure kueue according to their k8s configuration. Yet, we will not introduce API configuration which may turn out unnecessary over time. |
5387923
to
1ce0cf4
Compare
@trasc Thank you for responding to my questions. It seems that I missed reading codes somehow. |
SGTM |
1ce0cf4
to
e1ded24
Compare
Use `spec.managedBy` to detect delegatable jobs. Enable live status updates for batch/Jobs. No longer keep the multikueue admission check state `Pending` when the job is running in a worker cluster.
e1ded24
to
cbb7107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one naming nit from me.
I think we should also have defaulting of managedBy field for Jobs, as we do for JobSet. when the feature gate is enabled.
@trasc would you like to extend this PR or follow up?
Foillow-up I think @mbobrovskyi has some experience around this topic. |
pkg/features/kube_features.go
Outdated
PrioritySortingWithinCohort: {Default: true, PreRelease: featuregate.Beta}, | ||
MultiKueue: {Default: false, PreRelease: featuregate.Alpha}, | ||
LendingLimit: {Default: false, PreRelease: featuregate.Alpha}, | ||
MultiKueueBatchJobWithManagadBy: {Default: false, PreRelease: featuregate.Alpha}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MultiKueueBatchJobWithManagadBy: {Default: false, PreRelease: featuregate.Alpha}, | |
MultiKueueBatchJobWithManagedBy: {Default: false, PreRelease: featuregate.Alpha}, |
almost there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
8beb725
to
0486135
Compare
/lgtm |
LGTM label has been added. Git tree hash: c5295e560277a3d5f7d1a565c48a78ec03f90d2e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) * [multikueue] Use batch/Job `spec.managedBy` field. Use `spec.managedBy` to detect delegatable jobs. Enable live status updates for batch/Jobs. No longer keep the multikueue admission check state `Pending` when the job is running in a worker cluster. * Review remarks * [multikueue] Add `MultiKueueBatchJobWithManageBy` featuregate * Review remarks * Review remarks * Fix linter issues.
/release-note-edit
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use
spec.managedBy
to detect delegatable jobs.Enable live status updates for batch/Jobs.
No longer keep the multikueue admission check state
Pending
when the job is running in a worker cluster.Which issue(s) this PR fixes:
Relates to #693
Special notes for your reviewer:
Does this PR introduce a user-facing change?