-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor go dependencies #2403
Vendor go dependencies #2403
Conversation
Hi @pajakd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/ok-to-test |
It looks like commands like this: Are not pointing to the vendor folder |
Yes, this command returns an empty string if the vendor directory is present. What is more problematic is that |
/retest |
/retest |
So, it looks like it decreases the runtime of Command |
Re: make verify We probably need to change the verify rules to exclude the vendor folder. It might be formatting or doing similar things. |
Dockerfile
Outdated
# Copy the Go Modules manifests | ||
COPY go.mod go.mod | ||
COPY go.sum go.sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove these 2 lines too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Also need to update https://github.com/kubernetes-sigs/kueue/blob/main/cmd/importer/Dockerfile |
/retest |
/retest |
/retest |
"There are no nodes that your pod can schedule" -- looks like too many build jobs ran in parallel. Let me retry. |
/retest |
Fixed the problems with verify (had to exclude /vendor directory from It looks like the speedup in build time is small (or none). The only benefit from vendored dependencies would be more hermetic build. |
/test pull-kueue-build-image-main (curious if it's consistently faster) |
/test pull-kueue-build-image-main |
It looks like the builds are between 20 to 30s faster. @tenzen-y wdyt? |
I think we also need a change in |
As far as I understand with our configuration ( |
/lgtm |
/hold cancel |
LGTM label has been added. Git tree hash: 7ac2f43ec02fa39c02831222f9456b4929058c11
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, pajakd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I understand the valuables of the vendor. |
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I ran
go mod vendor
in the main directory. I would like to verify if having the dependencies vendored shortens build time (to help decide in the discussion #2374).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?