Vendor go dependencies

[pajakd]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I ran go mod vendor in the main directory. I would like to verify if having the dependencies vendored shortens build time (to help decide in the discussion #2374).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

Hi @pajakd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	125d92f
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6672b091cd8f4400089d80fa

[tenzen-y]

/ok-to-test

[alculquicondor]

It looks like commands like this:

https://github.com/kubernetes-sigs/kueue/blob/6ecaa877ee65791e6333f147fafcbb7888039a03/Makefile-deps.mk#L99C20-L99C84

Are not pointing to the vendor folder

[pajakd]

Yes, this command returns an empty string if the vendor directory is present.

What is more problematic is that /vendor directory only contains Go-packages (golang/go#26366). So, the files (the CRD .yaml definitions) that we are trying to copy here are not in the vendored package directory.

[pajakd]

/retest

[pajakd]

/retest

[pajakd]

So, it looks like it decreases the runtime of build-image-main target (hard to assess exactly as the runtimes vary quite significantly from run to run).

Command make verify, updated a number of files in /vendor directory -- I committed the changes and only then verify-main passed. However, if I try to run go mod vendor now it would revert the changes made by make verify. Not sure what to do with it.

[alculquicondor]

Re: make verify

We probably need to change the verify rules to exclude the vendor folder. It might be formatting or doing similar things.

[alculquicondor]

I think we can remove these 2 lines too

[pajakd]

Done.

[alculquicondor]

Also need to update https://github.com/kubernetes-sigs/kueue/blob/main/cmd/importer/Dockerfile

[pajakd]

/retest

[pajakd]

/retest

[pajakd]

/retest

[pajakd]

"There are no nodes that your pod can schedule" -- looks like too many build jobs ran in parallel. Let me retry.

[pajakd]

/retest

[pajakd]

Fixed the problems with verify (had to exclude /vendor directory from gofmt).

It looks like the speedup in build time is small (or none).

The only benefit from vendored dependencies would be more hermetic build.

[alculquicondor]

/test pull-kueue-build-image-main

(curious if it's consistently faster)

[alculquicondor]

/test pull-kueue-build-image-main

[alculquicondor]

It looks like the builds are between 20 to 30s faster.

@tenzen-y wdyt?

[alculquicondor]

I think we also need a change in .github/dependabot.yaml https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#vendor

[pajakd]

As far as I understand with our configuration (package-ecosystem: "gomod") we don't need to change anything. From the documentation "Don't use this option if you're using gomod as Dependabot automatically detects vendoring for this tool.". Additional reference: https://github.blog/changelog/2020-10-19-dependabot-go-mod-tidy-and-vendor-support/

[alculquicondor]

/lgtm
/approve

[alculquicondor]

/hold cancel

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 7ac2f43ec02fa39c02831222f9456b4929058c11

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, pajakd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tenzen-y]

It looks like the builds are between 20 to 30s faster.

@tenzen-y wdyt?

I understand the valuables of the vendor.

[alculquicondor]

/retest
Flaky #2429