Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kjobctl] Add list job #2413

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[kjobctl] Add list job #2413

merged 1 commit into from
Jul 10, 2024

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add list job on kjobctl.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 14, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 14, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 73a1ee0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/667ea1800bba1c00086184ee

@mbobrovskyi mbobrovskyi force-pushed the feature/kjobctl-list-job branch 7 times, most recently from 54543e9 to 4404de1 Compare June 17, 2024 13:14
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 17, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/kjobctl-list-job branch 4 times, most recently from bd520c3 to 1008fa0 Compare June 17, 2024 14:51
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi
Copy link
Contributor Author

/assign @trasc

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2024
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi mbobrovskyi force-pushed the feature/kjobctl-list-job branch 3 times, most recently from 3e78356 to 3b5aef3 Compare June 26, 2024 11:12
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2024
@mbobrovskyi
Copy link
Contributor Author

/retest

@mbobrovskyi mbobrovskyi force-pushed the feature/kjobctl-list-job branch 2 times, most recently from 63f98d3 to 26163e8 Compare June 28, 2024 09:33
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 28, 2024
trasc
trasc reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

cmd/experimental/kjobctl/pkg/cmd/list/helpers.go Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/pkg/cmd/list/list_job.go Outdated Show resolved Hide resolved
trasc
trasc reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 38ae18f6dc8fcd2912794175ca278066380348a2

@mbobrovskyi
Copy link
Contributor Author

/cc @mwielgus

@mbobrovskyi
Copy link
Contributor Author

/cc @alculquicondor

@trasc
Copy link
Contributor

trasc commented Jul 10, 2024

To unblock the describe job PR let's merge this now and address any potential issues in a followup.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 503bc68 into kubernetes-sigs:main Jul 10, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jul 10, 2024
@mbobrovskyi mbobrovskyi deleted the feature/kjobctl-list-job branch July 10, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IrvingMg IrvingMg IrvingMg left review comments

@trasc trasc trasc left review comments

@mimowo mimowo Awaiting requested review from mimowo

@kerthcet kerthcet Awaiting requested review from kerthcet

@mwielgus mwielgus Awaiting requested review from mwielgus

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mbobrovskyi @k8s-ci-robot @trasc @IrvingMg