Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multikueue] KEP add subcomponents and integration details. #2436

Merged
merged 3 commits into from
Jun 19, 2024
Merged

[multikueue] KEP add subcomponents and integration details. #2436

merged 3 commits into from
Jun 19, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Jun 18, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Add subcomponents and integration details in MultiKueue's KEP.

Which issue(s) this PR fixes:

Relates to #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 18, 2024
@trasc
Copy link
Contributor Author

trasc commented Jun 18, 2024

/hold
for #2373

@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 089a092
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6672fa359ac5900008e23698

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2024
@trasc trasc mentioned this pull request Jun 18, 2024
Open
5 tasks
@trasc trasc force-pushed the multikueue-kep-components-details branch from 48b0524 to 30567eb Compare June 18, 2024 12:35
@trasc trasc force-pushed the multikueue-kep-components-details branch 2 times, most recently from 8936fee to a874976 Compare June 18, 2024 14:30
alculquicondor
alculquicondor reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also please add yourself as one of the authors of this KEP. Credit were credit is due :)

keps/693-multikueue/README.md Outdated Show resolved Hide resolved
keps/693-multikueue/README.md Show resolved Hide resolved
keps/693-multikueue/README.md Outdated Show resolved Hide resolved
keps/693-multikueue/README.md Outdated Show resolved Hide resolved
keps/693-multikueue/README.md Show resolved Hide resolved
keps/693-multikueue/README.md Outdated Show resolved Hide resolved
@trasc trasc force-pushed the multikueue-kep-components-details branch from a874976 to 5f0292c Compare June 19, 2024 06:57
@trasc trasc force-pushed the multikueue-kep-components-details branch from 5f0292c to 0a5f39b Compare June 19, 2024 10:36
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 19, 2024
@trasc
Copy link
Contributor Author

trasc commented Jun 19, 2024

/unhold

/cc @tenzen-y

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2024
mimowo
mimowo reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think this update will be a very valuable resource when designing new features on top of the MultiKueue.

Left two recommendations.

@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2024
@trasc
Copy link
Contributor Author

trasc commented Jun 19, 2024

/retest

@alculquicondor
Copy link
Contributor

/lgtm
/approve

Many thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 90213e222cd230c89e1497cddf5b5b02c8cac9d5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 26d1be5 into kubernetes-sigs:main Jun 19, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jun 19, 2024
@trasc trasc deleted the multikueue-kep-components-details branch June 20, 2024 04:25
Fiona-Waters pushed a commit to Fiona-Waters/kueue that referenced this pull request Jun 25, 2024
@trasc @Fiona-Waters
[multikueue] KEP add subcomponents and integration details. (kubernet…
c0c8d4e 
…es-sigs#2436)

* [multikueue] KEP add subcomponents and integration details.

* Update kep's milestones.

* Add config
tenzen-y
tenzen-y reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for this updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mszadkow mszadkow mszadkow left review comments

@mimowo mimowo mimowo left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@trasc @alculquicondor @k8s-ci-robot @mszadkow @mimowo @tenzen-y