-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multikueue] KEP add subcomponents and integration details. #2436
[multikueue] KEP add subcomponents and integration details. #2436
Conversation
/hold |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
48b0524
to
30567eb
Compare
8936fee
to
a874976
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also please add yourself as one of the authors of this KEP. Credit were credit is due :)
a874976
to
5f0292c
Compare
5f0292c
to
0a5f39b
Compare
/unhold /cc @tenzen-y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I think this update will be a very valuable resource when designing new features on top of the MultiKueue.
Left two recommendations.
/retest |
/lgtm Many thanks! |
LGTM label has been added. Git tree hash: 90213e222cd230c89e1497cddf5b5b02c8cac9d5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…es-sigs#2436) * [multikueue] KEP add subcomponents and integration details. * Update kep's milestones. * Add config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for this updating.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add subcomponents and integration details in MultiKueue's KEP.
Which issue(s) this PR fixes:
Relates to #693
Special notes for your reviewer:
Does this PR introduce a user-facing change?