Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kjobctl] Add describe job #2438

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[kjobctl] Add describe job #2438

merged 1 commit into from
Jul 30, 2024

Conversation

IrvingMg
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add describe job command to kjobctl.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 18, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 0e5c21b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66a0a31f0852360008650bfb

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2024
@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch from 120d264 to 731801c Compare June 20, 2024 14:10
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 20, 2024
@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch 2 times, most recently from b162fb9 to 3a9874e Compare June 20, 2024 18:04
@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch from 3a9874e to 18b6c0e Compare June 24, 2024 19:52
@IrvingMg
Copy link
Contributor Author

/test all

@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch from 18b6c0e to 9cb8704 Compare June 25, 2024 10:31
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2024
@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch from 9cb8704 to fa3f517 Compare June 27, 2024 08:40
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2024
@IrvingMg
Copy link
Contributor Author

/test all

@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch from fa3f517 to 403ff3d Compare June 27, 2024 11:05
@IrvingMg
Copy link
Contributor Author

/retest

@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch from 403ff3d to 092fdcf Compare June 27, 2024 11:07
@IrvingMg
Copy link
Contributor Author

/retest

@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch from 092fdcf to 2499205 Compare June 28, 2024 09:29
@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch from 33940e6 to acdeed6 Compare July 10, 2024 14:47
@IrvingMg IrvingMg marked this pull request as ready for review July 10, 2024 14:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
trasc
trasc reviewed Jul 11, 2024
View reviewed changes
cmd/experimental/kjobctl/pkg/cmd/describe/describe.go Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/pkg/cmd/describe/describe.go Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/pkg/cmd/describe/describe.go Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/pkg/cmd/describe/describe.go Show resolved Hide resolved
cmd/experimental/kjobctl/pkg/cmd/describe/describe_printer.go Outdated
printAnnotationsMultiline(w, "Annotations", job.Annotations)
if controlledBy := printController(job); len(controlledBy) > 0 {
w.Write(IndentLevelZero, "Controlled By:\t%s\n", controlledBy)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it make sense to only print the values coming for the profile's RequiredFlags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that we should print only RequiredFlags as we're going to have 5 properties max. Maybe we can make sure that those in the required flags are printed too but it might be useful to show the other properties as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of properties printed has been updated.

CC: @mwielgus

@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch 3 times, most recently from 349ffb9 to 4047af2 Compare July 11, 2024 16:32
@alculquicondor
Copy link
Contributor

cc @pajakd

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 15, 2024
@alculquicondor
Copy link
Contributor

/assign

@mwielgus
Copy link
Contributor

Can we have a sample output of describe job?

@IrvingMg
Copy link
Contributor Author

Can we have a sample output of describe job?

Here it is

Name:           sample-profile-fzw66
Namespace:      default
Labels:         kjobctl.x-k8s.io/profile=sample-profile
Parallelism:    3
Completions:    3
Start Time:     Thu, 18 Jul 2024 15:57:10 +0200
Pods Statuses:  3 Active (0 Ready) / 0 Succeeded / 0 Failed
Pod Template:
  Containers:
   sample-container:
    Port:       <none>
    Host Port:  <none>
    Command:
      sleep
      30s
    Args:
      30s
    Requests:
      cpu:     1
      memory:  200Mi
    Environment:
      GREETING:   Warm greetings to
      HONORIFIC:  The Most Honorable
    Mounts:
      /data/redis from redis-storage (rw)
  Volumes:
   redis-storage:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:     
    SizeLimit:  <unset>

@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch 3 times, most recently from 9e0ca16 to 41be556 Compare July 23, 2024 10:10
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2024
@IrvingMg IrvingMg force-pushed the feature/kjobctl-describe-job branch from 41be556 to 0e5c21b Compare July 24, 2024 06:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@trasc
Copy link
Contributor

trasc commented Jul 30, 2024

/lgtm
/approve

We can do additional changes in a follow-up if needed.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c1afb422be4609436ac08b7a5f59430d1f7e36e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IrvingMg, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit a128ae3 into kubernetes-sigs:main Jul 30, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Jul 30, 2024
@trasc trasc deleted the feature/kjobctl-describe-job branch July 30, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszadkow mszadkow mszadkow left review comments

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@trasc trasc trasc left review comments

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@alculquicondor alculquicondor

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
7 participants
@IrvingMg @k8s-ci-robot @alculquicondor @mwielgus @trasc @mszadkow @mbobrovskyi