Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.7] [MultiKueue] Do not reject JobSet when ClusterQueue does not exist #2442

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[release-0.7] [MultiKueue] Do not reject JobSet when ClusterQueue does not exist #2442

merged 1 commit into from
Jun 19, 2024

Conversation

vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented Jun 19, 2024 •
edited by k8s-ci-robot

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

This is a cherry-pick of #2425

Special notes for your reviewer:

Does this PR introduce a user-facing change?

MultiKueue: Do not reject a JobSet if the corresponding cluster queue doesn't exist

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 19, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit cd19dc8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6672badb481fe70008e747fc

@vladikkuzn vladikkuzn force-pushed the automated-cherry-pick-of-#2425-upstream-release-0.7 branch from b210c4e to fd823ba Compare June 19, 2024 10:36
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2024
@vladikkuzn vladikkuzn force-pushed the automated-cherry-pick-of-#2425-upstream-release-0.7 branch from fd823ba to 27cc77d Compare June 19, 2024 10:37
@vladikkuzn
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 19, 2024
@vladikkuzn vladikkuzn changed the title Automated cherry pick of #2425 upstream release 0.7 [release-0.7] [MultiKueue] Do not reject JobSet when ClusterQueue does not exist Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 19, 2024
@vladikkuzn vladikkuzn force-pushed the automated-cherry-pick-of-#2425-upstream-release-0.7 branch from 27cc77d to cd19dc8 Compare June 19, 2024 11:02
@vladikkuzn vladikkuzn marked this pull request as ready for review June 19, 2024 11:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mimowo June 19, 2024 11:05
@vladikkuzn
Copy link
Contributor Author

/assign @vladikkuzn @mimowo

@mimowo
Copy link
Contributor

mimowo commented Jun 19, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2c8efacc158aa9b492cddbec76621c5316b25c43

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit aa682c9 into kubernetes-sigs:release-0.7 Jun 19, 2024
16 checks passed
@vladikkuzn vladikkuzn deleted the automated-cherry-pick-of-#2425-upstream-release-0.7 branch June 19, 2024 13:16
@alculquicondor
Copy link
Contributor

/kind bug

@alculquicondor
Copy link
Contributor

/release-note-edit

MultiKueue: Do not reject a JobSet if the corresponding cluster queue doesn't exist

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@kerthcet kerthcet Awaiting requested review from kerthcet

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@mimowo mimowo

@vladikkuzn vladikkuzn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vladikkuzn @k8s-ci-robot @mimowo @alculquicondor