-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for ProvisioningRequest's BookingExpired condition #2445
Provide support for ProvisioningRequest's BookingExpired condition #2445
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign @yaroslava-serdiuk |
please, fix the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits
/lgtm
LGTM label has been added. Git tree hash: 672b58a98791f6ae8859027913fbce4da7767f21
|
10ab30a
to
a4ef4c7
Compare
/lgtm |
LGTM label has been added. Git tree hash: db579ea45ac6d17bbcd2a970814e4e724cd4c40b
|
/lgtm |
e41ca2a
to
2345c81
Compare
/retest |
3b3727f
to
d6b5169
Compare
Co-authored-by: Yaroslava Serdiuk <yaroslava@google.com>
51dff1b
to
c3e44e1
Compare
g.Expect(k8sClient.Get(ctx, wlKey, &updatedWl)).To(gomega.Succeed()) | ||
|
||
g.Expect(workload.IsEvictedByDeactivation(&updatedWl)).To(gomega.BeTrue(), "The workload should be evicted by deactivation") | ||
util.ExpectEvictedWorkloadsTotalMetric(cq.Name, kueue.WorkloadEvictedByDeactivation, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be called after Eventually (again, to avoid Eventually inside Eventually)
/approve |
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, PBundyra, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
LGTM label has been added. Git tree hash: 40d4bf69dd56dfa928a62b0e00715cd864d1d9b9
|
/release-note-edit
|
/release-note-edit
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Provide support for the new ProvisioningRequest's condition
BookingExpired
. When a Workload is Admitted this Condition has no effect. If Workload is still waiting for admission due to others AdmissionChecks running, then with respect to retry policy it, the Provisioning AdmissionCheck gets retried or rejected.Which issue(s) this PR fixes:
Fixes #2041
Special notes for your reviewer:
Does this PR introduce a user-facing change?