-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set default log timestamp format #247
set default log timestamp format #247
Conversation
|
Welcome @cmssczy! |
Hi @cmssczy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-cla |
d6f1de6
to
5ed335b
Compare
/ok-to-test |
5ed335b
to
a23c617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, cmssczy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is great, it bothered me quite a bit, but I was lazy to lookup how to change it :) |
Signed-off-by: cmssczy smartczy@outlook.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Currently all log timestamps are
epoch
by default. I think we can set the default log format toRFC3339NanoTimeEncoder
to improve readability.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
before
after