[kueuectl] Add create resourceflavor command. #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mbobrovskyi
changed the title
mbobrovskyi
force-pushed
the
feature/kueuectl-create-flavor-command
branch
3 times, most recently
from
6e94c7b
to
80b6541
Compare
k8s-ci-robot
added
size/XL
mbobrovskyi
force-pushed
the
feature/kueuectl-create-flavor-command
branch
from
80b6541
to
ee73ad5
Compare
|
/test all |
mbobrovskyi
force-pushed
the
feature/kueuectl-create-flavor-command
branch
5 times, most recently
from
5933747
to
3734acb
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @trasc |
trasc
reviewed
Jul 4, 2024
mbobrovskyi
force-pushed
the
feature/kueuectl-create-flavor-command
branch
3 times, most recently
from
24ba393
to
0b2a918
Compare
mbobrovskyi
force-pushed
the
feature/kueuectl-create-flavor-command
branch
2 times, most recently
from
8b97a84
to
819f77a
Compare
|
/cc @alculquicondor |
Comment on lines
93
to
94
| "[--taints KEY=VALUE:EFFECT] " + | ||
| "[--taints KEY[=VALUE]:EFFECT] " + |
There was a problem hiding this comment.
Suggested change
| "[--taints KEY=VALUE:EFFECT] " + | |
| "[--taints KEY[=VALUE]:EFFECT] " + | |
| "[--node-taints KEY[=VALUE]:EFFECT] " + |
|
|
||
| cmd.Flags().StringToStringVar(&o.NodeLabels, nodeLabelsFlagName, nil, | ||
| "Labels that associate the ResourceFlavor with Nodes that have the same labels.") | ||
| cmd.Flags().StringSliceVar(&o.UserSpecifiedTaints, taintsFlagName, nil, |
There was a problem hiding this comment.
Suggested change
| cmd.Flags().StringSliceVar(&o.UserSpecifiedTaints, taintsFlagName, nil, | |
| cmd.Flags().StringSliceVar(&o.NodeTaints, taintsFlagName, nil, |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
mbobrovskyi
force-pushed
the
feature/kueuectl-create-flavor-command
branch
from
819f77a
to
bc30dc3
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 971a553e8251e52e0c3e507aeb55274a31a97752
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add
kueuectl create resourceflavorcommand.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?