[kjobctl][builder] Detect surplus flags #2534
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
| return noCompletionsSpecifiedErr | ||
| } | ||
| missing := requiredSet.Difference(providedSet) | ||
| extra := providedSet.Difference(requiredSet) |
There was a problem hiding this comment.
Not sure if this is correct. We should allow all flags to be applied, but only if it's possible to add to this profile. So we need to know all possible flags on each builder or template.
For example, PodTemplate don't have parallelism. So we can't use this flag.
There was a problem hiding this comment.
Since the profile is the place where the admin will configure the needed flags we should use that list.
There was a problem hiding this comment.
Yes, it's correct for required fields. But what about optional?
There was a problem hiding this comment.
Do we have the concept of "optional flag"?
There was a problem hiding this comment.
@alculquicondor @mwielgus WDYT?
There was a problem hiding this comment.
Yes, we might. Some values might be prepopulated in the template. While currently most of the flags are required, we may soon add additional ones like image name.
There was a problem hiding this comment.
When there is the case we can think of adding the API support for that kind of flag, for now I think that hard-coding a list of flags that are usable or not for interactive and job is not the way to go.
|
/assign @mwielgus |
|
cc @pajakd |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Detect unnecessary profile flags provided.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?